Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50021

POLICY: Support for %k and %l datetime conversion specifiers

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.9
    • Libraries
    • MOODLE_29_STABLE

      While working on MDL-49974 It was observed that %l is not supported and unit test was failing because of it.
      Also %P is supported which means lowercase in linux and uppercase in windows.
      http://php.net/manual/en/function.strftime.php
      https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx

      stronk7 suggested,
      A) If we want to allow %k, %l and other non-zero formatters... then we'll need to hack timestamp_to_date_string() badly with hacks like the $fixday and $fixhour ones.
      B) If we don't want to allow those formatters... then IMO it would be great to ban them officially (docs required). An surely that same function can be also a good place to, with debugging enabled, perform a simple regexp looking for invalid ones and to warn about them.

            Unassigned Unassigned
            rajeshtaneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.