Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50040

Renderer subtypes should find templates in the "templates" directory only.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.9
    • Fix Version/s: None
    • Component/s: HTML and CSS
    • Labels:
    • Testing Instructions:
      Hide
      1. Apply patch file attached to this issue
      2. Go to the event monitor subscription page and verify TEST is added to the page
      3. Go to the template library and verify a template for the tool_monitor can be displayed (it just says TEST)
      1. Create a file at theme/clean/templates/tool_monitor/test.mustache (Put anything in the file you want)
      2. Repeat 2 & 3 and verify that TEST has changed
      Show
      Apply patch file attached to this issue Go to the event monitor subscription page and verify TEST is added to the page Go to the template library and verify a template for the tool_monitor can be displayed (it just says TEST) Create a file at theme/clean/templates/tool_monitor/test.mustache (Put anything in the file you want) Repeat 2 & 3 and verify that TEST has changed
    • Affected Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50040-master
    • Pull Master Diff URL:

      Description

      There is a coding error when generating the file name of the template to search for - so it's not possible to use renderer subtypes properly with templates.

      Further more - it becomes restrictive to limit subtypes from using templates in other subtypes from the same plugin - and harder for themers to determine the folder in which to overwrite a template. We should ignore the subtype everywhere when searching for a template.

        Attachments

          Issue Links

          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50085 Improvements to template searching paths (less magic)

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Dave Cooper
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: