Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50059

The code for rendering a header has a theme specific check (BAD!)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9
    • 2.9
    • Themes
    • MOODLE_29_STABLE
    • MOODLE_29_STABLE
    • MDL-50059-master
    • Hide

      Change your theme to clean and set a logo in the clean theme settings.

      Verify the logo shows up in the header of every page.

      Change your theme to more and set a logo in the more theme settings.

      Verify the logo shows up in the header of every page.

      Verify the performance is not significantly worse with this patch.

      Show
      Change your theme to clean and set a logo in the clean theme settings. Verify the logo shows up in the header of every page. Change your theme to more and set a logo in the more theme settings. Verify the logo shows up in the header of every page. Verify the performance is not significantly worse with this patch.

    Description

      See lib/outputrenderers.php line 4129:

      if (isset($heading) && $heading == '<div class="logo"></div>') {
      

      This is checking if the theme is using a logo and printing the logo instead of the context header.

      An alternative would be overriding the full_header renderer in the renderer for clean.

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Frédéric Massart Frédéric Massart
              Andrew Lyons Andrew Lyons
              Adrian Greeve Adrian Greeve
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15