Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50059

The code for rendering a header has a theme specific check (BAD!)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Change your theme to clean and set a logo in the clean theme settings.

      Verify the logo shows up in the header of every page.

      Change your theme to more and set a logo in the more theme settings.

      Verify the logo shows up in the header of every page.

      Verify the performance is not significantly worse with this patch.

      Show
      Change your theme to clean and set a logo in the clean theme settings. Verify the logo shows up in the header of every page. Change your theme to more and set a logo in the more theme settings. Verify the logo shows up in the header of every page. Verify the performance is not significantly worse with this patch.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50059-master

      Description

      See lib/outputrenderers.php line 4129:

      if (isset($heading) && $heading == '<div class="logo"></div>') {
      

      This is checking if the theme is using a logo and printing the logo instead of the context header.

      An alternative would be overriding the full_header renderer in the renderer for clean.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Andrew Nicols
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15