Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.1
Affects Version/s: 2.6.10, 2.7.7, 2.8.5
Component/s: Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-50063~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/MDL-54205...MDL-50063
Testing Instructions:
Hide

As far as the change is 100% in tests (but 1 tiny unset)...

Run unit tests under linux/mac and windows. They should pass without any failure related with open/busy/unlink files.
Show
As far as the change is 100% in tests (but 1 tiny unset)... Run unit tests under linux/mac and windows. They should pass without any failure related with open/busy/unlink files.

gc_collect_cycles() was introduced to pass unit test by ~~MDL-47675~~ (c42d18183a633625745d089523971de8e6aaadaa), which is hiding actual problems of files not being closed properly in some places.

As part of this issue, please review and try remove unneeded gc_collect_cycles() and fix files which are not closed properly.

Discovered while testing

MDL-49998 editpdf unit test failure under windows

Closed

is a regression caused by

MDL-47675 phpunit failures on windows due files being left open

Closed

is blocked by

MDL-54205 Many windows phpunit errors introduced in 3.1 (unclosed files)

Closed

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Rajesh Taneja

Peer reviewer:: Rajesh Taneja

Integrator:: Andrew Lyons

Tester:: cameron1729

Participants:: Andrew Lyons, cameron1729, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Petr Skoda, Rajesh Taneja

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 30/Apr/15 9:59 PM

Updated:: 14/May/16 5:33 AM

Resolved:: 14/May/16 5:32 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify