Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50063

Review gc_collect_cycles() introduced by MDL-47675

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.10, 2.7.7, 2.8.5
    • Fix Version/s: 3.1
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      As far as the change is 100% in tests (but 1 tiny unset)...

      • Run unit tests under linux/mac and windows. They should pass without any failure related with open/busy/unlink files.
      Show
      As far as the change is 100% in tests (but 1 tiny unset)... Run unit tests under linux/mac and windows. They should pass without any failure related with open/busy/unlink files.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      gc_collect_cycles() was introduced to pass unit test by MDL-47675 (c42d18183a633625745d089523971de8e6aaadaa), which is hiding actual problems of files not being closed properly in some places.

      As part of this issue, please review and try remove unneeded gc_collect_cycles() and fix files which are not closed properly.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Andrew Nicols
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16