Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50083

Locked submission attempts do not unlock when reopened

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing a locked submission set to reopen automatically

      1. Create an assignment with 'Attempts reopened' set to 'Automatically until pass' and the submit button enabled. Set grade to pass to 50
      2. As a student, add a submission. Do not submit the assignment
      3. As a teacher, 'Prevent submission changes' for the students submission
      4. Grade the student 49/100. The submission will be reopened. Ensure the submission no longer states 'Submission changes not allowed'
      5. As a student, try and resubmit to the assignment. Ensure that the student is able to make submission changes

      Testing a locked submission that is manually reopened

      1. Create an assignment with 'Attempts reopened' set to Manual
      2. As a student, add a submission. Do not submit the assignment
      3. As a teacher, 'Prevent submission changes' for the student's submission
      4. As a teacher, 'Allow another attempt' for the student's submissions. Ensure the submission no longer states 'Submission changes not allowed'
      5. As a student, try and resubmit to the assignment. Ensure that the student is able to make submission changes
      Show
      Testing a locked submission set to reopen automatically Create an assignment with 'Attempts reopened' set to 'Automatically until pass' and the submit button enabled. Set grade to pass to 50 As a student, add a submission. Do not submit the assignment As a teacher, 'Prevent submission changes' for the students submission Grade the student 49/100. The submission will be reopened. Ensure the submission no longer states 'Submission changes not allowed' As a student, try and resubmit to the assignment. Ensure that the student is able to make submission changes Testing a locked submission that is manually reopened Create an assignment with 'Attempts reopened' set to Manual As a student, add a submission. Do not submit the assignment As a teacher, 'Prevent submission changes' for the student's submission As a teacher, 'Allow another attempt' for the student's submissions. Ensure the submission no longer states 'Submission changes not allowed' As a student, try and resubmit to the assignment. Ensure that the student is able to make submission changes
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      master_MDL-50083
    • Pull Master Diff URL:

      Description

      A 'locked' (prevent submission changes) assignment that is reopened does not unlock when reopened and therefore does not allow the student to resubmit.

      The UI does not give you the open to unlock the submission as the submission has been reopened. A URL can be generated to unlock the submission, but this isn't really a workaround for academic staff.

      Not sure if the {assign_user_flags} table needs to related to each submission, or whether a resubmission should automatically remove any existing lock?

      (Tested on 2.7 and qa.moodle.net)

      Steps to replicate

      1. Create an assignment with resubmissions set to automatically reopen until pass and the submit button enabled. Set grade to pass to 50
      2. As a student, add an assignment. Do not submit the assignment
      3. As a teacher, 'Prevent submission changes' for the students submission
      4. Grade the student 49/100. The submission will be reopened
      5. As a student, try and resubmit to the assignment. As it is locked, the student will not be able to make submission changes

        Attachments

          Activity

            People

            Assignee:
            gregor89 Greg Faller
            Reporter:
            gregor89 Greg Faller
            Peer reviewer:
            John Okely
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Mar/16