Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50084

Pix icon renderable does not implement templatable

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Themes
    • Labels:

      Description

      As per the docs here: https://docs.moodle.org/dev/Templates

      The pix icon renderable does not implement templatable (export_for_template). Also the "helper" for pix does not allow classes, and bypasses the renderers so it cannot be modified by php in a theme.

      A typical thing to do in themes is override pix_icon with a renderer than uses font awesome, this is not possible with the pix_helper so it should be removed.

      We should fix this before the 2.9 release so the template system is in good shape when plugins start to use it.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15