Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50084

Pix icon renderable does not implement templatable

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.9
    • 2.9
    • Themes

    Description

      As per the docs here: https://docs.moodle.org/dev/Templates

      The pix icon renderable does not implement templatable (export_for_template). Also the "helper" for pix does not allow classes, and bypasses the renderers so it cannot be modified by php in a theme.

      A typical thing to do in themes is override pix_icon with a renderer than uses font awesome, this is not possible with the pix_helper so it should be removed.

      We should fix this before the 2.9 release so the template system is in good shape when plugins start to use it.

      Attachments

        Issue Links

          Activity

            People

              davecooper Dave Cooper
              damyon Damyon Wiese
              Damyon Wiese Damyon Wiese
              Andrew Lyons Andrew Lyons
              Rajesh Taneja Rajesh Taneja
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15