Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50085

Improvements to template searching paths (less magic)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.9
    • 2.9
    • Themes
    • MOODLE_29_STABLE
    • MOODLE_29_STABLE
    • MDL-50085-master
    • Hide

      Check that pix icons work.

      Check page loading performance is not worse after this patch.

      Check that the template library still works.

      Add a folder "user/templates" and create a file in there "user/templates/test.mustache"

      Verify the new template is listed in the template library under the core_user subsystem.

      Show
      Check that pix icons work. Check page loading performance is not worse after this patch. Check that the template library still works. Add a folder "user/templates" and create a file in there "user/templates/test.mustache" Verify the new template is listed in the template library under the core_user subsystem.

    Description

      The search paths for templates is currently a bit too flexible. E.g. if you request a template core/blah from a plugin renderer it will search for plugin/blah and then core/blah. This was based on how the renderers work, but is too flexible and confusing. It will be faster and more predictable to search only in the specified.

      Also - core subsystems must be allowed to have a templates folder. This will be important to separate the reusable generic templates from ones specific to a subsystem.

      Note - this is how it is documented: https://docs.moodle.org/dev/Templates

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Frédéric Massart Frédéric Massart
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Rajesh Taneja Rajesh Taneja
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15