Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50115

Grunt on windows builds the entire tree, every time.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9.5, 3.0.3
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      1. On windows command prompt do grunt --root=admin/tool/templatelibrary/amd and ensure it only runs only the amd tasks.
      2. Try some other variations and ensure grunt --root=path/to/dir matches the behaviour of cd path/to/dir && grunt (you can't test the non-root alternitve on windows)
      3. Provide a --root which doesn't exist and ensure the job fails gracefully with a fatal error
      4. Repeat the same tests on linux and ensure they match the cd alteratnive
      Show
      On windows command prompt do grunt --root=admin/tool/templatelibrary/amd and ensure it only runs only the amd tasks. Try some other variations and ensure grunt --root=path/to/dir matches the behaviour of cd path/to/dir && grunt (you can't test the non-root alternitve on windows) Provide a --root which doesn't exist and ensure the job fails gracefully with a fatal error Repeat the same tests on linux and ensure they match the cd alteratnive
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50115-master
    • Pull Master Diff URL:

      Description

      On linux it will let you run grunt in a subdirectory and it will only build that directory. On windows we cant do this easily because grunt hides the current working directory.

      I think it's possible to get around by requiring windows devs using "grunt -b ." to change the base directory - which is what this issue is about.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50001 Moodle Gruntfile.js will not work on Windows because it does not have the PWD environment variable.

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has been marked as being related by

          New Feature - A new Moodle feature which has yet to be developed. MDL-49817 Development - Watch for JS/LESS changes and compile once a file is saved

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-53059 Grunt fails to build YUI modules when in a yui subdirectory, builds AMD instead

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Andrew Lyons Andrew Lyons
              Integrator:
              David Monllaó David Monllaó
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Mar/16