Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50127

Required fields in database activity breaks layout

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Create two of each type of field - one required and one not required of each (to save time start with the attached mod_data_allentrytypes.mbz backup file)
        1. Only 1 date, 4 URL fields two with autolink, two without it
      2. Go to templates, click reset, then save
      3. In each supported browser
        1. View the add entry page
        2. Ensure it displays correctly
        3. Modify the template to have no tables
        4. Make sure it still displays ok
        5. Change to a RTL language (e.g. hebrew)
        6. Make sure the fields display correctly (no tables)
        7. Reset the template
        8. Make sure the fields display correctly (with tables)
      4. Tab through each field in NVDA or JAWS, make sure the required fields read out as "Required field"
        1. The most important field to check would be the required URL with autolink. Make sure it doesn't say required field more than once.

      Test 2

      1. Download the Moodle1.9backup.with.user.data.zip backup file
      2. Edit each field to make it required (only one of each type there)
      3. Make the urls autolinked
      4. Test on both LTR and RTL languages that the asterisk appears in the correct spot, not in the center
      Show
      Test 1 Create two of each type of field - one required and one not required of each (to save time start with the attached mod_data_allentrytypes.mbz backup file) Only 1 date, 4 URL fields two with autolink, two without it Go to templates, click reset, then save In each supported browser View the add entry page Ensure it displays correctly Modify the template to have no tables Make sure it still displays ok Change to a RTL language (e.g. hebrew) Make sure the fields display correctly (no tables) Reset the template Make sure the fields display correctly (with tables) Tab through each field in NVDA or JAWS, make sure the required fields read out as "Required field" The most important field to check would be the required URL with autolink. Make sure it doesn't say required field more than once. Test 2 Download the Moodle1.9backup.with.user.data.zip backup file Edit each field to make it required (only one of each type there) Make the urls autolinked Test on both LTR and RTL languages that the asterisk appears in the correct spot, not in the center
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50127-master-squashed
    • Pull Master Diff URL:
    • Sprint:
      Team Beards Sprint 7, Team Beards Sprint 9, Team Beards Sprint 10
    • Issue size:
      Small

      Description

      Steps to reproduce:

      1. Add new database activity
      2. Add 3 text fields, one set to required, two not required

      Expected results:

      • The add template field alighs the 'label' with the input

      Actual results:

      • The required Asterix messes with the layout, there is no way to get them to align in the standard template

      NOTE: This may seem minor, but people won't like their existing modules being mesed up

        Attachments

        1. jira-capture-screenshot-20150506-165430-838.png
          149 kB
          John Okely
        2. jira-capture-screenshot-20150511-161604-732.png
          4 kB
          John Okely
        3. jira-capture-screenshot-20150511-165449-804.png
          7 kB
          John Okely
        4. jira-capture-screenshot-20150511-165627-872.png
          9 kB
          John Okely
        5. MDL-50127.png
          8 kB
          Damyon Wiese
        6. mod_data_allentrytypes.mbz
          73 kB
          John Okely
        8. requiredfields-gap.png
          7 kB
          John Okely
        9. Screen Shot 2015-05-06 at 08.45.29.png
          64 kB
          Dan Poltawski
        10. Screen Shot 2015-07-28 at 12.36.50.png
          70 kB
          Dan Poltawski

          Issue Links

          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-3977 META: Upgrade moodle.org to 2.9

          • Minor - Minor loss of function where workaround is possible
          • Resolved
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-64583 Required fields in database activity still breaks layout

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-5583 allow teachers to specify certain fields in database activity as required

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              johno John Okely
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              David Monllaó
              Integrator:
              Dan Poltawski
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15