Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50145

Notices on dashboard page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9, 3.0
    • Fix Version/s: 2.9.1
    • Component/s: Lesson
    • Testing Instructions:
      Hide

      Test on all supported DBs

      Test 1
      1. Create a fresh install (important as we want the primary keys for lesson_attempt and lesson_branch to start at the same point).
      2. Turn debugging on the site.
      3. Create a course and enrol a user.
      4. Create a lesson.
      5. Add an essay question and a content page to the lesson.
      6. Log in as the enrolled user and complete this lesson (click on the content page button).
      7. Click on 'Dashboard' in the navigation menu.
      8. Ensure there is no notice about duplicate values.
      Test 2
      1. Run the behat test mod/lesson/tests/behat/lesson_student_dashboard.feature
      Show
      Test on all supported DBs Test 1 Create a fresh install (important as we want the primary keys for lesson_attempt and lesson_branch to start at the same point). Turn debugging on the site. Create a course and enrol a user. Create a lesson. Add an essay question and a content page to the lesson. Log in as the enrolled user and complete this lesson (click on the content page button). Click on 'Dashboard' in the navigation menu. Ensure there is no notice about duplicate values. Test 2 Run the behat test mod/lesson/tests/behat/lesson_student_dashboard.feature
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50145_master

      Description

      From my comment on MDL-49065

      I am getting the following notices when I login as a student

      {{Did you remember to make the first column something unique in your call to get_records? Duplicate value '6' found in column 'id'.

      line 791 of /lib/dml/pgsql_native_moodle_database.php: call to debugging()
      line 454 of /mod/lesson/lib.php: call to pgsql_native_moodle_database->get_records_sql()
      line 47 of /blocks/course_overview/locallib.php: call to lesson_print_overview()
      line 75 of /blocks/course_overview/block_course_overview.php: call to block_course_overview_get_overviews()
      line 288 of /blocks/moodleblock.class.php: call to block_course_overview->get_content()
      line 230 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
      line 971 of /lib/blocklib.php: call to block_base->get_content_for_output()
      line 1023 of /lib/blocklib.php: call to block_manager->create_block_contents()
      line 473 of /lib/outputrenderers.php: call to block_manager->ensure_content_created()
      line 52 of /theme/clean/layout/columns3.php: call to core_renderer->standard_head_html()
      line 1015 of /lib/outputrenderers.php: call to include()
      line 945 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
      line 165 of /my/index.php: call to core_renderer->header()

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '5' found in column 'id'.

      line 791 of /lib/dml/pgsql_native_moodle_database.php: call to debugging()
      line 454 of /mod/lesson/lib.php: call to pgsql_native_moodle_database->get_records_sql()
      line 47 of /blocks/course_overview/locallib.php: call to lesson_print_overview()
      line 75 of /blocks/course_overview/block_course_overview.php: call to block_course_overview_get_overviews()
      line 288 of /blocks/moodleblock.class.php: call to block_course_overview->get_content()
      line 230 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
      line 971 of /lib/blocklib.php: call to block_base->get_content_for_output()
      line 1023 of /lib/blocklib.php: call to block_manager->create_block_contents()
      line 473 of /lib/outputrenderers.php: call to block_manager->ensure_content_created()
      line 52 of /theme/clean/layout/columns3.php: call to core_renderer->standard_head_html()
      line 1015 of /lib/outputrenderers.php: call to include()
      line 945 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
      line 165 of /my/index.php: call to core_renderer->header()}}

      I am not sure what exactly are the environment conditions that are triggering this, but this issue does seem to be the cause. Will wait for Stephen to respond before creating an issue.

      Thanks

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              ankit_frenz Ankit Agarwal
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                6/Jul/15