Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50228

Improve the overall feedback section of the quiz form

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to admin -> Plugins -> Activity modules -> Quiz
      2. Verify that 'Initial number of overall feedback fields' defaults to 2.
      3. Set 'Initial number of overall feedback fields' to 4.
      4. Create a new quiz. Verify that the number of text editors in the Overall feedback section of the form is 4.
      5. Type in 3 sets of feedback with grade boundaries and save.
      6. Re-edit the quiz, and verify that the form now has only 3 overall feedback boxes.
      7. Delete all the overall feedback fields and save.
      8. Re-edit the quiz, and verify that the form now only shows 1 overall feedback box.
      Show
      Go to admin -> Plugins -> Activity modules -> Quiz Verify that 'Initial number of overall feedback fields' defaults to 2. Set 'Initial number of overall feedback fields' to 4. Create a new quiz. Verify that the number of text editors in the Overall feedback section of the form is 4. Type in 3 sets of feedback with grade boundaries and save. Re-edit the quiz, and verify that the form now has only 3 overall feedback boxes. Delete all the overall feedback fields and save. Re-edit the quiz, and verify that the form now only shows 1 overall feedback box.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      At the moment, when you create a new quiz, there are 5 overall feedback boxes, and when you edit an existing quiz, you get either (current number of feedback * 1.5) or 5 boxes, whichever is more.

      (E.g. if the quiz had 5 feedbacks, then you get 7 boxes on the edit form. If it had 10, you get 15 boxes.)

      This is not ideal. It takes up a lot of space on the form.

      Our experience of the question type forms (e.g. answers and hints) is that once the quiz is created, the best thing is to have a number of form fields that matches the number of repeat items that actually exist, since adding more is a rare action, and so it is not a problem to click the "Space for 3 more ..." in that case. (We probably always need to show one box, to avoid errors.)

      For new quizzes, we should pick a sensible number of boxes. The only data I have ready access to is the OU, and the data there shows:

      number of feedbacks number of quizzes
      0 6088
      1 112
      2 17
      3 302
      4 335
      5 135
      6 6
      8 96

      From that, it looks like starting the form with 5 boxes would be right. (Before seeing the data, my guess was 2 empty boxes for a new quiz.)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Davo Smith
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15