Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50250

Remove obsolete param $obsolete from p() function

XMLWordPrintable

    • MOODLE_30_STABLE
    • MOODLE_30_STABLE
    • MDL-50250-master
    • Easy
    • Hide

      p() function is not used that often - but it can be found in one of those files - so test with any of the modules below:
      data/field/radiobutton/mod.html
      data/field/picture/mod.html
      data/field/multimenu/mod.html
      data/field/file/mod.html
      data/field/textarea/mod.html
      data/field/number/mod.html
      data/field/text/mod.html
      data/field/checkbox/mod.html
      data/field/date/mod.html
      data/field/menu/mod.html
      data/field/url/mod.html
      data/field/latlong/mod.html
      survey/report.php
      glossary/editcategories.html
      glossary/editcategories.php
      glossary/export.php
      glossary/formats.php
      forum/prune.html

      Make sure the $obsolete parameter is not used anywhere in core.

      Show
      p() function is not used that often - but it can be found in one of those files - so test with any of the modules below: data/field/radiobutton/mod.html data/field/picture/mod.html data/field/multimenu/mod.html data/field/file/mod.html data/field/textarea/mod.html data/field/number/mod.html data/field/text/mod.html data/field/checkbox/mod.html data/field/date/mod.html data/field/menu/mod.html data/field/url/mod.html data/field/latlong/mod.html survey/report.php glossary/editcategories.html glossary/editcategories.php glossary/export.php glossary/formats.php forum/prune.html Make sure the $obsolete parameter is not used anywhere in core. 

      /**
      		 
      ...
      		 
       * @todo Remove obsolete param $obsolete if not used anywhere
      		 
       *
      		 
       * @param string $var the string potentially containing HTML characters
      		 
       * @param boolean $obsolete no longer used.
      		 
       * @return string
      		 
       */
      		 
      function p($var, $obsolete = false) {
      		 
          echo s($var, $obsolete);
      		 
      }

      Second parameter is not used anywhere, I've checked with:
      ack-grep ' p(.*,'

            tmuras Tomasz Muras
            tmuras Tomasz Muras
            Simey Lameze Simey Lameze
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.