Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50254

Missing aliasing in Mustache Filesystem Loader

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.9, 2.9 regressions
    • Fix Version/s: 2.9.1
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      Set theme to "clean" in config.php
      Go to template library admin page
      Change theme to "more" in config.php WITHOUT reloading the page.
      Click on a template from the library - verify the template loads and there are no 500 errors in the network tab.

      Show
      Set theme to "clean" in config.php Go to template library admin page Change theme to "more" in config.php WITHOUT reloading the page. Click on a template from the library - verify the template loads and there are no 500 errors in the network tab.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50254-master

      Description

      On file /lib/classes/output/mustache_template_finder.php the theme_config class must be aliased ( use theme_config; ) otherwise PHP will spawn this error:

      Class 'core\output\theme_config' not found in /lib/classes/output/mustache_template_finder.php on line 72

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            zaerl Francesco Bigiarini
            Peer reviewer:
            Damyon Wiese
            Integrator:
            Dan Poltawski
            Tester:
            John Okely
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              6/Jul/15