Loading...

XML

Word

Printable

Affected Branches:
MOODLE_30_STABLE, MOODLE_402_STABLE
Fixed Branches:
MOODLE_403_STABLE
Epic Link:
TODOs in core
Pull from Repository:
https://github.com/paulholden/moodle/
Pull Main Branch:
~~MDL-50272~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-50272
Testing Instructions:
Hide

Execute the following:

$ git grep -A2 get_file_size

Confirm the only matches are the original method (which triggers debugging) and note in upgrade.txt
Show
Execute the following: $ git grep -A2 get_file_size Confirm the only matches are the original method (which triggers debugging) and note in upgrade.txt

We have a comment in core code as follows:

TODO ~~MDL-33297~~ remove this function completely?

This was not done in ~~MDL-33297~~.
After greping the code it doesn't look like it is being used in core at all.
Perhaps it is safe to deprecate it.

has been marked as being related by

MDL-33297 File picker doesn't display some recently uploaded files as a student.

has to be done before

MDL-78706 Final removal of repository get_file_size

Participants:: Adrian Greeve, CiBoT, Dan Marsden, Huong Nguyen, Kim Jared Lucas, Matteo Scaramuccia, Matt Porritt, Paul Holden

Estimated:

Remaining:

Logged:

18m