Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50331

Gradebook update warning notification uses notifysuccess

    XMLWordPrintable

Details

    • MOODLE_28_STABLE

    Description

      The code for showing warnings when gradebook things change use a notifysucess state, which seems inappropriate.

      https://github.com/moodle/moodle/blob/v2.8.6/grade/lib.php#L489-L534

      All the PHP code uses "warning" in it's variable names, and the text clearly sounds like something that's not a success, but a warning.

      Presumably this is because, since Moodle's front-end generally doesn't have an intermediate "warning" status, comparable to Bootstrap's alert-warning, the developer had the choice of notifyerror and notifysuccess thought that error was too strong in this case.

      Maybe it's time to add an intermediate level of notification?

      Attachments

        Issue Links

          will help resolve

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-50241 Create Bootstrap3 core theme

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              Unassigned Unassigned
              bawjaws David Scotson
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: