[MDL-50346] Remove the restriction to forbid subdirectories in the templates directory - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.9, 3.8
Fix Version/s: 3.8
Component/s: JavaScript
Labels:

Affected Branches:
MOODLE_29_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-50346~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/414eca8923...MDL-50346-master
Testing Instructions:
Hide

Download 50346.zip from the issue

Unzip it in the moodle root

Log in as admin

Open Site admin => Development => Template library

Search for core/modal

Confirm that you see an exact match and nothing in a theme directory.

Select core/modal

Confirm that you see an example which says:

This is no longer a modal in any theme.

Search for mod_forum/form/checkbox_toggle

Confirm that you see an exact match and nothing in a theme directory.

Select it

Confirm that you see an example which says:

Fail this issue if you see this message in the boost theme. It should only work in boost.

Search for local/foo/bar

Confirm that you see a match for "theme_boost/local/foo/bar"

Select it

Confirm that you see an example which says:

You should be able to see this in any theme!

Switch to the classic theme

Search for core/modal

Confirm that you see an exact match and nothing in a theme directory.

Select core/modal

Confirm that you see an example which says:

This is no longer a modal in any theme.

Search for mod_forum/form/checkbox_toggle

Confirm that you see an exact match and nothing in a theme directory.

Select it

Confirm that you see an example which says:

Fail this issue if you see this message in the boost theme. It should only work in classic.

Search for local/foo/bar

Confirm that you see a match for "theme_boost/local/foo/bar"

Select it

Confirm that you see an example which says:

You should be able to see this in any theme!
Show
Download 50346.zip from the issue Unzip it in the moodle root Log in as admin Open Site admin => Development => Template library Search for core/modal Confirm that you see an exact match and nothing in a theme directory. Select core/modal Confirm that you see an example which says: This is no longer a modal in any theme. Search for mod_forum/form/checkbox_toggle Confirm that you see an exact match and nothing in a theme directory. Select it Confirm that you see an example which says: Fail this issue if you see this message in the boost theme. It should only work in boost. Search for local/foo/bar Confirm that you see a match for " theme_boost/local/foo/bar " Select it Confirm that you see an example which says: You should be able to see this in any theme! Switch to the classic theme Search for core/modal Confirm that you see an exact match and nothing in a theme directory. Select core/modal Confirm that you see an example which says: This is no longer a modal in any theme. Search for mod_forum/form/checkbox_toggle Confirm that you see an exact match and nothing in a theme directory. Select it Confirm that you see an example which says: Fail this issue if you see this message in the boost theme. It should only work in classic. Search for local/foo/bar Confirm that you see a match for " theme_boost/local/foo/bar " Select it Confirm that you see an example which says: You should be able to see this in any theme!

Sprint:
Internationals - 3.8 Sprint 3, Internationals - 3.8 Sprint 4

Description

In ~~MDL-50085~~ the possibility to use subdirectories in the »templates« directory as been removed. This restriction makes it more difficult to structure templates. Mustache works with partials - it would be helpful to able to use the »partials« directory in the »templates« directory.

At line 106 of »lib/classes/output/mustache_template_finder.php« the test for a »/« has been added.
{{
if (strpos($templatename, '/') !== false)

{ throw new coding_exception('Templates cannot be placed in sub directories (' . s($name) . ' requested)'); }

}}

When I comment out the test subdirectory works again.

Why is this test needed? I don't see the point.

Please remove this restriction again.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

50346.zip
4 kB
25/Jul/19 9:29 PM
MDL-50346_Boost.jpg
46 kB
08/Aug/19 1:36 PM
MDL-50346_Classic.jpg
38 kB
08/Aug/19 1:36 PM

Issue Links

caused a regression

MDL-66384 PHP Mustache tokenizer is not fetching full template name for templates in a subdir

Closed

has been marked as being related by

MDL-67205 Incorrect information in theme/upgrade.txt

Closed

MDL-66192 Allow subdirectories for AMD modules

Closed

is blocked by

MDL-62497 Add a new transpilation tool for ES6

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Urs Hunkler

Peer reviewer:: Simey Lameze

Integrator:: Jun Pataleta

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Damyon Wiese, Frédéric Massart, Jun Pataleta, Simey Lameze, Stanislav Korolenko, Urs Hunkler

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 7 Vote for this issue

Watchers:: 15 Start watching this issue

Dates

Created:: 26/May/15 2:43 AM

Updated:: 11/Nov/19 3:40 AM

Resolved:: 09/Aug/19 4:56 PM

Fix Release Date:: 18/Nov/19

Time Tracking

Estimated:

Remaining:

Logged:

1d 2h