Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50378

Calendar preferences page has multiple pagetype definitions and can loose blocks

    XMLWordPrintable

    Details

    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE

      Description

      calendar/preferences.php defines two different page layouts and this can cause it to loose blocks. This is especially bad if you've got a theme which only displays side-post blocks on that page - you loose all blocks and ability to add blocks.

      I've given two ways to reproduce it... the theme modifying way is the easy one..

      Steps to reproduce 1.

      1. Apply the attached patch (which switches block regions around for clean theme)
      2. Go to calendar
      3. Click on the preferences button

      Expected results:

      1. The blocks page is displayed with standard block
        Actual results:
      2. All blocks are lost, because they are all side-pre blocks and now auto-moved

      Steps to reproduce 2

      1. Turn editing on
      2. Go to a calendar page
      3. Configure the navigation block to be on the right side on calendar-* pages
      4. Click on the preferences button on a calendar page to get to calendar/preferences.php

      Expected results:

      1. You are able to see all calendar blocks visible on this page

      Actual results:

      1. The navigation block is lost, because the block isn't auto-flipped

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16