Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50451

mod_forum: Students should not receive posts from hidden courses

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Not a bug
    • Affects Version/s: Future Dev
    • Fix Version/s: None
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Background:

      Forum digests are being sent out to students from a hidden course.

      A hidden course should not have any of its posts/content sent to
      students while the instructor is developing the course or before the
      course is unhidden.

      Testing instructions:

      Students profile for "email digest type" is set to "No Digest (Single
      email per forum post)"

      1. The first test. In this test I have hidden the forum and then added a
      new discussion (hidden discussion). - "Student does not receive any
      forum notifications"
      2. Second test. This time I have hidden the course and then added a new
      discussion (hidden course). "Student does not receive any forum
      notifications"

      Students profile now set to "Complete (Daily email with full posts)"

      1. The first test. In this test I have hidden the forum and then added a
      new discussion (hidden discussion). - "Student does not receive the
      daily digest"
      2. Second test. This time I have hidden the course and then added a new
      discussion (hidden course). "Student receives the daily digest"

      This is the same when setting the students profile to "Subjects (Daile
      digest with subjects only)"

      Steps to replicate;

      1. log into hidden course
      2. Enroll student that has daily digest set in profile settings we have access to this students email account..
      3. Create a forum "Standard forum for general use", with forced
      subscription all other settings as standard
      4. Create new discussion in said forum
      5. Student receives daily digest

      Show
      Background: Forum digests are being sent out to students from a hidden course. A hidden course should not have any of its posts/content sent to students while the instructor is developing the course or before the course is unhidden. Testing instructions: Students profile for "email digest type" is set to "No Digest (Single email per forum post)" 1. The first test. In this test I have hidden the forum and then added a new discussion (hidden discussion). - "Student does not receive any forum notifications" 2. Second test. This time I have hidden the course and then added a new discussion (hidden course). "Student does not receive any forum notifications" Students profile now set to "Complete (Daily email with full posts)" 1. The first test. In this test I have hidden the forum and then added a new discussion (hidden discussion). - "Student does not receive the daily digest" 2. Second test. This time I have hidden the course and then added a new discussion (hidden course). "Student receives the daily digest" This is the same when setting the students profile to "Subjects (Daile digest with subjects only)" Steps to replicate; 1. log into hidden course 2. Enroll student that has daily digest set in profile settings we have access to this students email account.. 3. Create a forum "Standard forum for general use", with forced subscription all other settings as standard 4. Create new discussion in said forum 5. Student receives daily digest
    • Workaround:
      Hide

      Hide the forum course module.

      Show
      Hide the forum course module.
    • Pull Master Branch:
      MDL-50451-master

      Description

      Currently, students receive form posts via email when the course is hidden. One of our clients has proposed that this in incorrect behaviour constituting a bug and I would like to submit this issue to the wider community for consideration and potential integration with standard Moodle.

      I have included a potential solution on Github. Please note that I used a database call that may be inefficient, so some peer review feedback on how to improve performance there could also be useful.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: