Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50484

Duplicate id's on pages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test true/false question on lesson
      1. Create a lesson and add true/false question
      2. Preview question and ensure answers have unique id's
      Unique id on define roles page.
      1. Go to Site administration ► Users ► Permissions ► Define roles
      2. Ensure all risks icon have a unique id.
      Navigation have unique id's
      1. Navigate to course
      2. Expand participants node and Badges node under "Current course"
      3. ensure the id of "Course blogs" is different to "Course badges"
      url resource have unique id.
      1. Create a url resource
      2. On editing page, ensure id of "external url" "choose a link" button has unique id on page.
      Grader report have unique coursehearder id.
      1. Create a course with multiple activities
      2. Go to grader report and add a category.
      3. enusre courseheder_categoryname is unique (categoryname is name of category and will vary)
      Adding notes have unique id for cotext select box.
      1. Create a course with few students enrolled.
      2. Go to paticipants page and select few students
      3. Select "Add a new note"
      4. Ensure each dropdown has a unique id (menustates_xx)
      Run behat with ~@javascript tag with php 5.6.4 or some version where you can see debug notice and ensure after the patch there is no debug notice.
      Show
      Test true/false question on lesson Create a lesson and add true/false question Preview question and ensure answers have unique id's Unique id on define roles page. Go to Site administration ► Users ► Permissions ► Define roles Ensure all risks icon have a unique id. Navigation have unique id's Navigate to course Expand participants node and Badges node under "Current course" ensure the id of "Course blogs" is different to "Course badges" url resource have unique id. Create a url resource On editing page, ensure id of "external url" "choose a link" button has unique id on page. Grader report have unique coursehearder id. Create a course with multiple activities Go to grader report and add a category. enusre courseheder_categoryname is unique (categoryname is name of category and will vary) Adding notes have unique id for cotext select box. Create a course with few students enrolled. Go to paticipants page and select few students Select "Add a new note" Ensure each dropdown has a unique id (menustates_xx) Run behat with ~@javascript tag with php 5.6.4 or some version where you can see debug notice and ensure after the patch there is no debug notice.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      wip-mdl-50484

      Description

      Upgrading to php 5.6.4 and running behat, lot of warnings started to appear. These warnings are coming from browserkit. I will add more information about each page as I go though the list, but they all seems to be appearing because of duplicate id's on the page which we should fix.

      1. Following appears on Grader report. With Editing on, look at source code and you will observe courseheader being used as id for multiple nodes.

        Warning: DOMDocument::importNode(): ID courseheader already defined in /home/rajesh/moodles/m/moodle/vendor/behat/mink-browserkit-driver/src/Behat/Mink/Driver/BrowserKitDriver.php on line 675
        

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16