Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50497

Menu divider colors are wrong if 'invert navbar' setting is selected.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.6
    • Fix Version/s: 2.8.7, 2.9.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Using Clean theme, go to Theme settings and add the following 'example' menu for this setting. 

        #
        		 
        About
        		 
        #
        		 
        Contact
        		 
        #
        		 
        Help
        		 
        #
        		 
        Notices
        		 
        #

      2. Save your settings.
      3. In Clean theme's Custom settings page change the navbar settings to 'Inverse'.
      4. Save settings.
      5. Verify that the navbar is now black and that the vertical divider lines in the top menubar are grey and NOT white.
      Show
      Using Clean theme, go to Theme settings and add the following 'example' menu for this setting. # About # Contact # Help # Notices # Save your settings. In Clean theme's Custom settings page change the navbar settings to 'Inverse'. Save settings. Verify that the navbar is now black and that the vertical divider lines in the top menubar are grey and NOT white.
    • Workaround:
      Hide

      Add this to Clean or More CSS Custom settings:

      .navbar.navbar-inverse .nav .divider

      { border-left: 1px solid #333; border-right: 1px solid #555; }

      See attached screen-shot of what it looks like with the css added above.

      Show
      Add this to Clean or More CSS Custom settings: .navbar.navbar-inverse .nav .divider { border-left: 1px solid #333; border-right: 1px solid #555; } See attached screen-shot of what it looks like with the css added above.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50497-M30
    • Pull Master Diff URL:

      Description

      If you add a # (hash character) in the Custom Menu textbox in Theme settings, and use either Clean or More themes, it adds a dividing line between the menu items. If you also opt to have an 'inverse' menubar (which is black) the grey/white divider line looks wrong in contrast to the black background. These dividers need to be shades of a darker grey.
      I have attached two images showing the Menu in the Clean theme, before and after correcting.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50383 Default custom menu dividers look bad when navbar-inverse is selected.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-46022 Add ability to create dividers in custom_menu

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50533 Dividers don't display well on responsive design

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50711 Custom menu horizontal divider colours need defining when navbar is inverted

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lazydaisy Mary Evans
              Reporter:
              lazydaisy Mary Evans
              Peer reviewer:
              Jetha Chan Jetha Chan
              Integrator:
              David Monllaó David Monllaó
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                6/Jul/15