Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE
    • Rank:
      11317

      Description

      I think some of the themes have a misplaced div closing tag in header.html, at least standard and standardlogo. I think this has been the case since around 1.5 (I first noticed it on a 1.5.3 site).

      If you try to change the background color of the header (by targetting #header-home on the front page, #header on all others) nothing visible happens. I think this is because the div is closed before, rather than after, the clearer div. If you move the closing tag to after the clearer div then what happens makes more sense, to me at least i.e. setting the background color on either of those id's creates a large rectangular header of the chosen color.

        Activity

        Hide
        Martin Dougiamas added a comment -

        From Joseph R?zeau (joseph.rezeau at uhb.fr) Sunday, 2 April 2006, 05:05 AM:

        Hi David,

        Are you talking about standard theme in 1.6 Beta_1 version? I do not see any problem of an unclosed <div> in the header.htm file. If you want to change the background color of e.g. #header-home on the home page and #header on the other pages, you have to set it in the .headermain class.

        Joseph

        From David Scotson (d.scotson at admin.gla.ac.uk) Sunday, 2 April 2006, 08:09 PM:

        When I try:

        .headermain

        {background-color: red;}

        I only get a small red rectangle around the course title/Moodle name, adding .headermenu only colours the small area around the logininfo, leaving two small red rectangles floating in space.

        This is testing on a fairly recent HEAD: Moodle 1.6 development (2006032200) with the Standard and StandardLogo themes. I'm using Firefox Web Developer Extension to add the single line to the CSS, but it is in line with what I've recently seen by editing the CSS file itself.

        Note that I'm not talking about an 'unclosed div', which would lead to validation problems, but a div that is closed too early, leading I think to a div that collapses completely into an invisible horizontal line.

        From Urs Hunkler (u.hunkler at elearningkontor.de) Sunday, 9 April 2006, 01:15 AM:

        You'r right David. To solve the error I added the clearfix class to both header divs and removed the clearer div in 1.6 beta 2 for the standard theme. My tests show that it works now.

        Show
        Martin Dougiamas added a comment - From Joseph R?zeau (joseph.rezeau at uhb.fr) Sunday, 2 April 2006, 05:05 AM: Hi David, Are you talking about standard theme in 1.6 Beta_1 version? I do not see any problem of an unclosed <div> in the header.htm file. If you want to change the background color of e.g. #header-home on the home page and #header on the other pages, you have to set it in the .headermain class. Joseph From David Scotson (d.scotson at admin.gla.ac.uk) Sunday, 2 April 2006, 08:09 PM: When I try: .headermain {background-color: red;} I only get a small red rectangle around the course title/Moodle name, adding .headermenu only colours the small area around the logininfo, leaving two small red rectangles floating in space. This is testing on a fairly recent HEAD: Moodle 1.6 development (2006032200) with the Standard and StandardLogo themes. I'm using Firefox Web Developer Extension to add the single line to the CSS, but it is in line with what I've recently seen by editing the CSS file itself. Note that I'm not talking about an 'unclosed div', which would lead to validation problems, but a div that is closed too early, leading I think to a div that collapses completely into an invisible horizontal line. From Urs Hunkler (u.hunkler at elearningkontor.de) Sunday, 9 April 2006, 01:15 AM: You'r right David. To solve the error I added the clearfix class to both header divs and removed the clearer div in 1.6 beta 2 for the standard theme. My tests show that it works now.
        Hide
        Michael Blake added a comment -

        Temp Reopen in order to close with a valid Resolution code.

        Show
        Michael Blake added a comment - Temp Reopen in order to close with a valid Resolution code.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: