Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-5051

Some themes header.html broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE

      Description

      I think some of the themes have a misplaced div closing tag in header.html, at least standard and standardlogo. I think this has been the case since around 1.5 (I first noticed it on a 1.5.3 site).

      If you try to change the background color of the header (by targetting #header-home on the front page, #header on all others) nothing visible happens. I think this is because the div is closed before, rather than after, the clearer div. If you move the closing tag to after the clearer div then what happens makes more sense, to me at least i.e. setting the background color on either of those id's creates a large rectangular header of the chosen color.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: