Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50563

Drag and drop of a hidden block causes it to not display dimmed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      The patch changes the base dragdrop JavaScript code, therefore we will need to check all areas that items that extend it. I can think of 3 places it is used:

      • blocks
      • course sections
      • activities

      Blocks

      Drag and dropping a hidden block

      1. In the Dashboard switch on customisation
      2. Hide a block
      3. Drag and drop that block to another location on the dashboard
      4. Confirm the block displays dimmed

      Drag and dropping a visible block

      1. In the Dashboard switch on customisation
      2. Drag and drop a visible block to another location on the dashboard
      3. Confirm the block is not dimmed

      Course sections

      Drag and dropping a hidden section

      1. In a course turn on editing
      2. Confirm all the sections are visible
      3. Hide a section
      4. Drag the hidden section over another section
      5. Confirm that the section that was dragged displays dimmed in its new location
      6. Confirm that the other sections are still displaying undimmed

      Drag and drop a visible section

      1. In a course turn on editing
      2. Drag the visible section over another section
      3. Confirm the dragged section displays undimmed
      4. Confirm the other sections display with their original visibility

      Activities

      Drag and dropping a hidden activity

      1. In a course with several activities turn on editing
      2. Hide one of the activities
      3. Drag and drop the hidden activity to another place in the course
      4. Confirm the activity still displays as dimmed
      5. Confirm the other activities still display as they did before the drag and drop

      Drag and dropping a visible activity

      1. In a course with several activities turn on editing
      2. Drag and drop a visible activity to another place in the course
      3. Confirm the activity still displays undimmed and looks the same as it did before
      4. Confirm the other activities in the course display as they did before

      Quiz

      1. Create a quiz with 3 questions
      2. Verify you can drag and drop the questions in a different order
      Show
      The patch changes the base dragdrop JavaScript code, therefore we will need to check all areas that items that extend it. I can think of 3 places it is used: blocks course sections activities Blocks Drag and dropping a hidden block In the Dashboard switch on customisation Hide a block Drag and drop that block to another location on the dashboard Confirm the block displays dimmed Drag and dropping a visible block In the Dashboard switch on customisation Drag and drop a visible block to another location on the dashboard Confirm the block is not dimmed Course sections Drag and dropping a hidden section In a course turn on editing Confirm all the sections are visible Hide a section Drag the hidden section over another section Confirm that the section that was dragged displays dimmed in its new location Confirm that the other sections are still displaying undimmed Drag and drop a visible section In a course turn on editing Drag the visible section over another section Confirm the dragged section displays undimmed Confirm the other sections display with their original visibility Activities Drag and dropping a hidden activity In a course with several activities turn on editing Hide one of the activities Drag and drop the hidden activity to another place in the course Confirm the activity still displays as dimmed Confirm the other activities still display as they did before the drag and drop Drag and dropping a visible activity In a course with several activities turn on editing Drag and drop a visible activity to another place in the course Confirm the activity still displays undimmed and looks the same as it did before Confirm the other activities in the course display as they did before Quiz Create a quiz with 3 questions Verify you can drag and drop the questions in a different order
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Steps to reproduce:

      • Clean theme
      • Chrome
      1. Hide a block
      2. Drag and drop it to another position

      Outcome: The block moves, but is not dimmed

      Expected: The block moves and remains dimmed

      Refresh the page and the block correctly shows that it is invisible

      At all times the menu is correct so this is a display issue only

        Attachments

          Activity

            People

            • Assignee:
              nmagill Neill Magill
              Reporter:
              nmagill Neill Magill
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Andrew Nicols
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15