Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50589

External gradereport_user::get_grades_table should regrade

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. As admin, enable "Mobile services": Plugins ► Web Services ► Mobile
      2. In a course, create an activity (like assignment) and grade manually any user
      3. Go to the Gradebook setup screen
      4. Change the aggregation method, or an item, or something.
      5. DO NOT display the gradebook!
      6. Using the mobile app, connect to the site using the user account
      7. Open the grades option in the course, ensure that you don't see errors in the grade columns
      8. Pull down to refresh the grades screen, check again that you don't see errors
      Show
      As admin, enable "Mobile services": Plugins ► Web Services ► Mobile In a course, create an activity (like assignment) and grade manually any user Go to the Gradebook setup screen Change the aggregation method, or an item, or something. DO NOT display the gradebook! Using the mobile app, connect to the site using the user account Open the grades option in the course, ensure that you don't see errors in the grade columns Pull down to refresh the grades screen, check again that you don't see errors
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50589-master

      Description

      When an item is marked as 'needsupdate', the report returns error for the associated items.

      In Moodle Web, the function grade_regrade_final_grades is called before displaying the gradebook to ensure that this does not happen.

      The external services which are using the gradebook should probably do the same thing.

      To reproduce

      1. Grade a user
      2. Go to the setup screen
      3. Change the aggregation method, or an item, or something.
      4. DO NOT display the gradebook just yet
      • Expected: Calling the WS returns the same data as the grade report
      • Actual: The grades display error

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Dani Palou
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ryan Wyllie
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/16