Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50610

custom_menu styles don't target properly when using upstream bootstrap plugins

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.9, 2.9 regressions, 3.0
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      • Create a nested custom menu using dividers - the example text is fine: 

        Moodle community|https://moodle.org
        		 
        -Moodle free support|https://moodle.org/support
        		 
        -###
        		 
        -Moodle development|https://moodle.org/development
        		 
        --Moodle Docs|http://docs.moodle.org|Moodle Docs
        		 
        --German Moodle Docs|http://docs.moodle.org/de|Documentation in German|de
        		 
        #####
        		 
        Moodle.com|http://moodle.com/

      • With a window wider than 980px, verify that it displays properly.
      • Resize your window to be narrower than 980px and verify that the dividers are horizontal rather than vertical.
      Show
      Create a nested custom menu using dividers - the example text is fine: Moodle community|https://moodle.org -Moodle free support|https://moodle.org/support -### -Moodle development|https://moodle.org/development --Moodle Docs|http://docs.moodle.org|Moodle Docs --German Moodle Docs|http://docs.moodle.org/de|Documentation in German|de ##### Moodle.com|http://moodle.com/ With a window wider than 980px, verify that it displays properly. Resize your window to be narrower than 980px and verify that the dividers are horizontal rather than vertical.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50610-master
    • Pull Master Diff URL:
    • Sprint:
      Team Beards Sprint 7

      Description

      The short of this issue is, our modded version of Bootstrap Collapse toggled the class .active - and the upstream version we now use using AMD toggles the class .in. Unfortunate.

      This can be easily fixed by simply retargeting the styles in question.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50533 Dividers don't display well on responsive design

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-49262 Delete the yui versions of the bootstrap plugins

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jethac Jetha Chan
              Reporter:
              jethac Jetha Chan
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: