Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50611

Don't use cURL command for downloading Composer

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-50611-master
    • Moderate
    • Hide
      1. Delete composer.phar
      2. Execute php admin/tool/behat/cli/init.php
      3. Verify that Composer is installed and updated as expected
      4. For Moodle 2.9 and 3.0dev, verify that composer.lock is unchanged

      Test above on Windows/Mac/Linux.

      Show
      Delete composer.phar Execute php admin/tool/behat/cli/init.php Verify that Composer is installed and updated as expected For Moodle 2.9 and 3.0dev, verify that composer.lock is unchanged Test above on Windows/Mac/Linux.

    Description

      At present, the test suite's testing_update_composer_dependencies() function attempts to download Composer via the curl command. Whilst cURL is installed and on the user's PATH on the vast majority of Linux distributions and all OS X releases, this poses an unnecessary hurdle for Windows users.

      Let's encourage best practice by not making it difficult for developers to fix their code. I'll add branches for all current Moodle releases shortly.

      Attachments

        Issue Links

          Activity

            People

              lukecarrier Luke Carrier
              lukecarrier Luke Carrier
              Rajesh Taneja Rajesh Taneja
              David Monllaó David Monllaó
              Simey Lameze Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                6/Jul/15