Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50661

Restyle "Clean" theme to use Logo and Header in Frontpage with smaller logo option in other pages.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      General stuff to test this:

      • Repeat all steps using both clean and more.
      • Use both RTL and LTR languages (just to make sure that the margins are correctly applied)
      1. Open the JS console, you SHOULD NOT have any image returned with http status code 404
      2. Without setting any small logo nor logo (unset them if you have any)
      3. Browse to the frontpage and to a course
      4. You SHOULD NOT see any .navbar .small-logo in non of these 2 pages
      1. Set a logo and uncheck site name checkbox (we uncheck it to test that the setting is only affecting if a small logo is set)
      2. Browse to the frontpage and to a course
      3. You SHOULD NOT see any .navbar .small-logo in non of these 2 pages
      4. You SHOULD see the logo displayed in the frontpage
      5. You SHOULD see the site name in both pages (in .navbar .brand)
      1. Set a small logo and check site name checkbox
      2. Browse to the frontpage
      3. You SHOULD see the logo displayed in the frontpage, you SHOULD NOT see any .navbar .small-logo and you SHOULD see the site name (in .navbar .brand)
      4. Browse to a course or to your profile page
      5. You SHOULD NOT see the logo displayed in the header and see the course name or your profile picture instead
      6. In .navbar, you SHOULD see the image you set as small logo in .navbar .small-logo along with the site name (in .navbar .brand)
      7. Reduce the window width to 700px
      8. Check that the margins are correctly applied
      9. Reduce to less than 480px width
      10. Note that .navbar .brand is not visible although, if you check the DOM, you can see is positioned outside the visible area
      1. Go to the theme settings again and uncheck site name + save changes
      2. Browse to a course or to your profile page
      3. You SHOULD NOT see the logo displayed in the header and see the course name or your profile picture instead
      4. You SHOULD see the image you set as small logo in .navbar .small-logo and you SHOULD NOT see the site name (.navbar .brand SHOULD NOT exist)
      Show
      General stuff to test this: Repeat all steps using both clean and more. Use both RTL and LTR languages (just to make sure that the margins are correctly applied) Open the JS console, you SHOULD NOT have any image returned with http status code 404 Without setting any small logo nor logo (unset them if you have any) Browse to the frontpage and to a course You SHOULD NOT see any .navbar .small-logo in non of these 2 pages Set a logo and uncheck site name checkbox (we uncheck it to test that the setting is only affecting if a small logo is set) Browse to the frontpage and to a course You SHOULD NOT see any .navbar .small-logo in non of these 2 pages You SHOULD see the logo displayed in the frontpage You SHOULD see the site name in both pages (in .navbar .brand) Set a small logo and check site name checkbox Browse to the frontpage You SHOULD see the logo displayed in the frontpage, you SHOULD NOT see any .navbar .small-logo and you SHOULD see the site name (in .navbar .brand) Browse to a course or to your profile page You SHOULD NOT see the logo displayed in the header and see the course name or your profile picture instead In .navbar, you SHOULD see the image you set as small logo in .navbar .small-logo along with the site name (in .navbar .brand) Reduce the window width to 700px Check that the margins are correctly applied Reduce to less than 480px width Note that .navbar .brand is not visible although, if you check the DOM, you can see is positioned outside the visible area Go to the theme settings again and uncheck site name + save changes Browse to a course or to your profile page You SHOULD NOT see the logo displayed in the header and see the course name or your profile picture instead You SHOULD see the image you set as small logo in .navbar .small-logo and you SHOULD NOT see the site name (.navbar .brand SHOULD NOT exist)
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-50661_master

      Description

      Right now, at least in Moodle 2.7, with the theme "Clean" if one uploads a logo it appears virtually on every page. I think for many it is right to have the logo on the frontpage only. Once one enters a course it is logical to have the course long name in its place.

      Or to put it another way: There need to be more options for the frontpage and course page design. Another example: In the old default theme one could upload two logos: one for the frontpage and (a smaller) one for all the other pages.

      For details see https://moodle.org/mod/forum/discuss.php?d=315537.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                15 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16