Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50700

course grade overview report doesn't respect course theme or course specific blocks.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Create a new course.
      2. Add an activity that has a gradebook item.
      3. Enrol a student.
      4. Add a block that is specific to that course and not available on the site homepage.

      5. Login as the student.
      6. View the grade overview report for that user in that course

      The blocks displayed must match the ones available on the course homepage. (This may fail if you didn't select the block to display on all pages. If that wasn't the case, adjust the block and try again.)

      Themes
      1. Create a new course.
      2. Add an activity that has a gradebook item.
      3. Enrol a student.
      4. Enable Course based themes.
      5. Set a different theme on the course than for the site.
      6. Login as the student and view the "Grade Overview Report"
      Ensure that the course theme is used rather than the site theme.

      Show
      1. Create a new course. 2. Add an activity that has a gradebook item. 3. Enrol a student. 4. Add a block that is specific to that course and not available on the site homepage. 5. Login as the student. 6. View the grade overview report for that user in that course The blocks displayed must match the ones available on the course homepage. (This may fail if you didn't select the block to display on all pages. If that wasn't the case, adjust the block and try again.) Themes 1. Create a new course. 2. Add an activity that has a gradebook item. 3. Enrol a student. 4. Enable Course based themes. 5. Set a different theme on the course than for the site. 6. Login as the student and view the "Grade Overview Report" Ensure that the course theme is used rather than the site theme.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      If a course is set to use a specific theme and the teacher is viewing the various grade reports, clicking on the "overview report" within the course grades area results in the theme switching to the site default theme instead of the course specific theme.

      I suspect this is due to the use of require_login(null) in grade/report/overview/index.php - if $courseid is set we should probably pass $course into require_login.

        Attachments

          Activity

            People

            Assignee:
            mr-russ Russell Smith
            Reporter:
            danmarsden Dan Marsden
            Peer reviewer:
            Ryan Wyllie
            Integrator:
            David Monllaó
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              21/Dec/15