Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50714

Posting in a forum unnecessarily relies on the capability 'mod/forum:movediscussions'

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Run behat suite for @mod_forum
      1. Create a visibly grouped forum in a course without groups, and another forum without any group settings
      2. Post a message to each group in the first forum, and another post to "All participants"
      3. Reply to each message
      4. Move each of the discussions from the first forum into the second forum
      5. Edit the first post in each discussion
        1. Confirm that you can select the group when editing
        2. Confirm that you can only see the 'All participants' group
      6. Change the group to 'All participants'
      7. Edit the reply in each discussion
        1. Confirm that you cannot select the group when editing
      8. Move each of the discussion back to the first forum
      9. Edit the first post in each discussion
        1. Confirm that you can select the group when editing
        2. Confirm that you can see all of the groups again
      10. Change the group in each post back (one discussion per group)
      11. Edit the reply in each discussion
        1. Confirm that you cannot select the group when editing

      You may also like to look how posting to groups in all three activity group modes works with:

      1. no groups
      2. student in one group
      3. student in multiple groups
      4. tutor in one group
      5. tutor in multiple groups

      Note: the behat tests cover all of the above.

      Show
      Run behat suite for @mod_forum Create a visibly grouped forum in a course without groups, and another forum without any group settings Post a message to each group in the first forum, and another post to "All participants" Reply to each message Move each of the discussions from the first forum into the second forum Edit the first post in each discussion Confirm that you can select the group when editing Confirm that you can only see the 'All participants' group Change the group to 'All participants' Edit the reply in each discussion Confirm that you cannot select the group when editing Move each of the discussion back to the first forum Edit the first post in each discussion Confirm that you can select the group when editing Confirm that you can see all of the groups again Change the group in each post back (one discussion per group) Edit the reply in each discussion Confirm that you cannot select the group when editing You may also like to look how posting to groups in all three activity group modes works with: no groups student in one group student in multiple groups tutor in one group tutor in multiple groups Note: the behat tests cover all of the above.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-50714-master
    • Sprint:
      Team Beards Sprint 9, Team Beards Sprint 10
    • Issue size:
      Small

      Description

      The 'posttomygroups' setting is only shown if the user has the capability 'mod/forum:movediscussions' - which seems unnecessary. In mod/forum/classes/post_form.php the following code exists causing this unnecessary requirement -

      $contextcheck = has_capability('mod/forum:movediscussions', $modulecontext) && empty($post->parent) && $groupcount > 1;
      if ($contextcheck) {
          if (has_capability('mod/forum:canposttomygroups', $modulecontext)
                             && !isset($post->edit)) {
              $mform->addElement('checkbox', 'posttomygroups', get_string('posttomygroups', 'forum'));
              $mform->addHelpButton('posttomygroups', 'posttomygroups', 'forum');
              $mform->disabledIf('groupinfo', 'posttomygroups', 'checked');
          }
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15