Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-5072

inconsistent behavior with names of students in essay grading

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: None
    • Component/s: Quiz
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE

      Description

      In the manual grading tab, there is a list of students. The student's names are clickable. However, one expects that when one clicks on a student's name, one should be taken to their profile. This is how it works elsewhere in Moodle. In this case it takes you to their quiz attempt. It would be better to have a link that says view answers or something like that for the particular student rather than use their name as the link for this purpose

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Mark Nielsen (man15 at humboldt.edu) Thursday, 6 April 2006, 12:27 PM:

          Attached is a some proposed fix. I don't have CVS access to /question so the best I can do at the moment is provide diffs. The changes are minimal.

          Here is what my CVS commit log would have look like:

          First attempt at fixing MDL-5072

          Added new column for grade all link

          User name no longer links to grade all, links to user profile

          Added collapsible to the table

          Changed the ID of the table to attempt to reuse styles

          Now uses fullname() to print user's name

          Found another bug - a string was hard coded - moved it to lang file

          From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 11 April 2006, 12:33 AM:

          Hi Mark, have you committed this yet?

          From Mark Nielsen (man15 at humboldt.edu) Tuesday, 11 April 2006, 01:28 AM:

          The following are fixed:

          Found another bug - a string was hard coded - moved it to lang file

          Now uses fullname() to print user's name

          I really don't like the fix that I came up with. It looks... odd. The table columns in the fix are set up like this:

          userpic / username / attempts / gradealllink

          Any suggestions or is the above acceptable?

          From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 11 April 2006, 03:02 AM:

          I don't see anything wrong with what you describe. I also don't think that people who use essay questions are likely to allow several attempts at a quiz.

          From Mark Nielsen (man15 at humboldt.edu) Tuesday, 11 April 2006, 04:01 AM:

          Then perhaps a better fix then would be that instead of having a row for each attempt, we just have a single link in the attempts column that says, Grade attempts, or Grade Attempts (X not graded).

          From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 11 April 2006, 04:07 AM:

          I would just call the link Grade. But I would also keep the column with the completion date but would call it Completed on.

          From Mark Nielsen (man15 at humboldt.edu) Tuesday, 11 April 2006, 10:23 AM:

          Now everything in my first comment is in CVS with the suggestions from Gustav.

          Show
          dougiamas Martin Dougiamas added a comment - From Mark Nielsen (man15 at humboldt.edu) Thursday, 6 April 2006, 12:27 PM: Attached is a some proposed fix. I don't have CVS access to /question so the best I can do at the moment is provide diffs. The changes are minimal. Here is what my CVS commit log would have look like: First attempt at fixing MDL-5072 Added new column for grade all link User name no longer links to grade all, links to user profile Added collapsible to the table Changed the ID of the table to attempt to reuse styles Now uses fullname() to print user's name Found another bug - a string was hard coded - moved it to lang file From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 11 April 2006, 12:33 AM: Hi Mark, have you committed this yet? From Mark Nielsen (man15 at humboldt.edu) Tuesday, 11 April 2006, 01:28 AM: The following are fixed: Found another bug - a string was hard coded - moved it to lang file Now uses fullname() to print user's name I really don't like the fix that I came up with. It looks... odd. The table columns in the fix are set up like this: userpic / username / attempts / gradealllink Any suggestions or is the above acceptable? From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 11 April 2006, 03:02 AM: I don't see anything wrong with what you describe. I also don't think that people who use essay questions are likely to allow several attempts at a quiz. From Mark Nielsen (man15 at humboldt.edu) Tuesday, 11 April 2006, 04:01 AM: Then perhaps a better fix then would be that instead of having a row for each attempt, we just have a single link in the attempts column that says, Grade attempts, or Grade Attempts (X not graded). From Gustav Delius (gwd2 at york.ac.uk) Tuesday, 11 April 2006, 04:07 AM: I would just call the link Grade. But I would also keep the column with the completion date but would call it Completed on. From Mark Nielsen (man15 at humboldt.edu) Tuesday, 11 April 2006, 10:23 AM: Now everything in my first comment is in CVS with the suggestions from Gustav.
          Hide
          mblake Michael Blake added a comment -

          assign to a valid user

          Show
          mblake Michael Blake added a comment - assign to a valid user

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: