Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50720

Highlight database entries that are not yet approved.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Purge all caches.
      • Log in as a teacher and open a course.
      • Create a new database activity, setting the "Entries -> Approval required" setting to "Yes".
      • Create a "text input" field in this database.
      • Click on "Templates" (to generate the default templates).
      • Enter three database records (filling the text filed with arbitrary data).
      • Click on "View list".
      • VERIFY: None of the list entries has a red background.
      • Click on "undo approval" for the second entry.
      • VERIFY: The second entry now has a red background.
      • Click on "View single".
      • VERIFY: Entry does not have a red background.
      • Click on "Undo approval".
      • VERIFY: Entry now has a red background.
      Show
      Purge all caches. Log in as a teacher and open a course. Create a new database activity, setting the "Entries -> Approval required" setting to "Yes". Create a "text input" field in this database. Click on "Templates" (to generate the default templates). Enter three database records (filling the text filed with arbitrary data). Click on "View list". VERIFY: None of the list entries has a red background. Click on "undo approval" for the second entry. VERIFY: The second entry now has a red background. Click on "View single". VERIFY: Entry does not have a red background. Click on "Undo approval". VERIFY: Entry now has a red background.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      In the database activity, with approval process enabled, it is currently difficult for teachers to see which entries in the database have already been approved. The only visual indication for a non-approved entry is the presence of the "approve" button (rather than the "undo approval" button for approved entries). However, the button is very small and also sends a confusing message - a "green tickmark" present means that the entry is not yet approved.

      As an easy fix, I suggest the following: The non-approved entries should, by default, be displayed with a different background colour (say, a pale red). This would give a clear indication to the teacher, and not influence the student view at all. If implemented via the template system, this would also be easy to configure on a case-by-case basis.

      (A patch will follow in a moment.)

        Attachments

          Issue Links

          has a QA test

          Functional Test - A test of a single Moodle feature MDLQA-27 A teacher can set that database activity entries require approval before being viewable by everyone

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Open

            Activity

              People

              Assignee:
              bostelm Henning Bostelmann
              Reporter:
              bostelm Henning Bostelmann
              Peer reviewer:
              Jetha Chan
              Integrator:
              David Monllaó
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15