Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50737

RSS - SimplePie: Improved 'invalid characters' message

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 2.9
    • Fix Version/s: 3.2
    • Component/s: RSS
    • Labels:
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE

      Description

      Just an Improvement I want to share.

      A feed with an encoding problem filled our logs without telling the feed url. Thats why I changed the corresponding line in /lib/simplepie/library/SimplePie.php, line 1386 to get more information about the mean feed:
      $this->error = sprintf('This XML document is invalid, likely due to invalid characters. XML error: %s at line %d, column %d, encoding %s, URL: %s', $parser->get_error_string(), $parser->get_current_line(), $parser->get_current_column(), $encoding, $this->feed_url);

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              pegenau Steffen Pegenau
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16