Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50757

Upgrade from moodle prior to 2.7 to current version will sometimes show a grade book warning.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.6, 2.9, 3.0
    • Fix Version/s: 2.8.7, 2.9.1
    • Component/s: Gradebook
    • Labels:
      None
    • Testing Instructions:
      Hide

      before upgrade (Please do in 2.7 or earlier)

      1. Create a course.
      2. Enrol a few students in the course
      3. Go to the gradebook
      4. Go to "Full view"
      5. Create a category
      6. Create a grade item in the new category.
      7. Change the grade max to be something different to 100. This is important in 2.8 and higher because it changes the category total to change.
      8. Edit the category total calculation and enter in a forumlar of some sort.
      9. Update the category maximum to be something different to 100 and the minimum to be something different to 0. (this will only work in 27 and lower versions)
      10. Go to the grade report and give some students a grade for the grade item in the category.
      11. Go to the user report and view the grades of the students.
      12. Take a screen shot for a comparison later.

      Upgrade

      1. Upgrade your code to the most recent patch
      2. Go to the gradebook and check that there is no warning message.
      3. Verify the grades did not change during the upgrade

      2.8 upgrade.

      1. Create a 2.8 instance from the weekly version 47cbd1b42da432ce3da1beadfaac4b5d4e1e23f7. (Last weeks stable release)
      2. Follow all of the "before upgrade" steps above to create a grade category with a maximum different to 100.
      3. Go to the user report and view the grades of the students.
      4. Take a screen shot for a comparison later.
      5. Run the upgrade and then check the gradebook. This time there should be a warning.
      6. Verify the grades did not change during the upgrade
      7. Accept the warning
      8. Verify the grades did change, because the max grade for the category is now correct.
      Show
      before upgrade (Please do in 2.7 or earlier) Create a course. Enrol a few students in the course Go to the gradebook Go to "Full view" Create a category Create a grade item in the new category. Change the grade max to be something different to 100. This is important in 2.8 and higher because it changes the category total to change. Edit the category total calculation and enter in a forumlar of some sort. Update the category maximum to be something different to 100 and the minimum to be something different to 0. (this will only work in 27 and lower versions) Go to the grade report and give some students a grade for the grade item in the category. Go to the user report and view the grades of the students. Take a screen shot for a comparison later. Upgrade Upgrade your code to the most recent patch Go to the gradebook and check that there is no warning message. Verify the grades did not change during the upgrade 2.8 upgrade. Create a 2.8 instance from the weekly version 47cbd1b42da432ce3da1beadfaac4b5d4e1e23f7. (Last weeks stable release) Follow all of the "before upgrade" steps above to create a grade category with a maximum different to 100. Go to the user report and view the grades of the students. Take a screen shot for a comparison later. Run the upgrade and then check the gradebook. This time there should be a warning. Verify the grades did not change during the upgrade Accept the warning Verify the grades did change, because the max grade for the category is now correct.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-50757-master

      Description

      If a moodle instance prior to 2.8 has calculated grade categories with a minimum or maximum grade total that is different to the rawgrademin and rawgrademax, the when upgrading to the latest version, they will see a warning in the grade book that there are fixes for the grade book that have no been applied.
      This is incorrectly stopping the grade values to show as they originally were shown prior to the upgrade. An upgrade from 2.7 or before to this version should also not show a grade book warning.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                6/Jul/15