[MDL-50811] Forum email replies to do not update completion tracking information - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.8.6, 2.9, 2.9.1
Fix Version/s: 2.8.9, 2.9.3
Component/s: Forum
Labels:
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/cameron1729/moodle.git
Pull Master Branch:
~~MDL-50811~~-master
Pull Master Diff URL:
https://github.com/cameron1729/moodle/compare/9382ac3...MDL-50811-master
Testing Instructions:
Hide

Test Plan A

Create a new course

Enrol a student

Create a new forum

Enable Completion tracking

Enable the 'Student must post discussions or replies' option

Create a new discussion

Post a reply to the discussion via email as the student

Confirm the forum is marked as completed

Test Plan B

Create a new course

Enrol a student

Create a new forum

Enable Completion tracking

Enable the 'Student must post replies' option

Create a new discussion

Post a reply to the discussion via email as the student

Confirm the forum is marked as completed
Show
Test Plan A Create a new course Enrol a student Create a new forum Enable Completion tracking Enable the 'Student must post discussions or replies' option Create a new discussion Post a reply to the discussion via email as the student Confirm the forum is marked as completed Test Plan B Create a new course Enrol a student Create a new forum Enable Completion tracking Enable the 'Student must post replies' option Create a new discussion Post a reply to the discussion via email as the student Confirm the forum is marked as completed

Description

When a user replies to a forum, that has completion tracking information enabled, their reply does not update the completion tracking status for the user in the forum.

Steps to Replicate:

Create a new forum
Enable Completion tracking
Enable either the 'Student must post discussions or replies' or 'Student must post replies' options
Create a new discussion
Post are reply to the discussion via email

Expected outcome:
Forum activity is marked as complete for the user who submitted the post via email

Additional notes:
It appears that it may only be necessary to add the same completion tracking snippet from the mod/forum/post.php file to the message processor. It may also be a good idea to wrap this in config if the community wants to differentiate between posts via the UI and via email and have different completion tracking settings.