[MDL-50816] Incorrect warning structure in core_notes_delete_notes - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.8.7, 2.9, 3.0
Fix Version/s: 2.8.8, 2.9.2
Component/s: Other
Labels:
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/jleyva/moodle.git
Pull Master Branch:
~~MDL-50816~~-master
Pull Master Diff URL:
https://github.com/jleyva/moodle/compare/9325cd9...MDL-50816-master
Testing Instructions:
1. Check that notes are enabled in Advanced Features
2. Create several notes for different users (site, course and personal notes)
3. Delete that notes and check that everything works as expected

Description

The warning structure is not correct, I noticed also that the condition for displaying the warning is never met since $DB->delete_records always return true and the warning or error messages were incorrect.

Attachments

Activity

People

Assignee:: Juan Leyva

Reporter:: Juan Leyva

Peer reviewer:: Simey Lameze

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Juan Leyva, Marina Glancy, Simey Lameze

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 11/Jul/15 1:41 AM

Updated:: 06/Aug/15 11:55 PM

Resolved:: 06/Aug/15 11:11 PM

Fix Release Date:: 14/Sep/15