Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50824

core_message::send_instance_messages does not translate {$a} in strings

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log into Moodle Mobile on a non-administrator account.
      2. Attempt to send a message to another user who is not on your contact list and has 'Prevent non-contacts from messaging me' checked in their messaging preference.
      3. Verify you receive an error message that does not read '{$a} only accepts messages from their contacts.'; the fullname of the user you attempted to message should be in place of {$a}.
      Show
      Log into Moodle Mobile on a non-administrator account. Attempt to send a message to another user who is not on your contact list and has 'Prevent non-contacts from messaging me' checked in their messaging preference. Verify you receive an error message that does not read '{$a} only accepts messages from their contacts.'; the fullname of the user you attempted to message should be in place of {$a}.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-50824-master
    • Pull Master Diff URL:

      Description

      The external function core_message::send_instance_messages does not properly translate the error string when the recipient does not accept messages from non contacts.

      The following code should pass the recipient full name:

      $errormessage = get_string('userisblockingyounoncontact', 'message');

        Attachments

          Issue Links

          Discovered while testing

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MOBILE-1064 Hide messages buttons in the profile page when messaging is disabled

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              c.d.smith Clem Smith
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Dan Poltawski
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16