Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50923

Frontpage layout is missing bodyclass 'content-only' when blocks are hidden

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.1, 3.0
    • Fix Version/s: 2.9.2
    • Component/s: JavaScript, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. hide all blocks on the page (for navigation and administration blocks you will have to do it in the block configuration
      2. turn editing mode off (you will have to go to the course because you hid the block)
      3. make sure the page is displayed full width

      test on clean/more/base themes
      note: do not dock blocks, content-only class is added by js then

      Show
      hide all blocks on the page (for navigation and administration blocks you will have to do it in the block configuration turn editing mode off (you will have to go to the course because you hid the block) make sure the page is displayed full width test on clean/more/base themes note: do not dock blocks, content-only class is added by js then
    • Workaround:
      Hide

      Add the following CSS to your theme's stylesheet or CSS Custom Settings, whichever is the easiest.

      .empty-region-side-pre.empty-region-side-post #region-main-box,
      .empty-region-side-pre.empty-region-side-post #region-main {
          width: 100%;
      }
      

      Show
      Add the following CSS to your theme's stylesheet or CSS Custom Settings, whichever is the easiest. .empty-region-side-pre.empty-region-side-post #region-main-box, .empty-region-side-pre.empty-region-side-post #region-main { width: 100%; }
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      wip-MDL-50923-master

      Description

      NB: This only affects BootstrapBase and Clean themes.
      This first became evident in the Demo site and relates to MDL-49094 which I thought covered page layout probabilities when blocks were docked or hidden. It does, however, look like Frontpage is missing the much needed bodyclass 'content-only' that reduces the long winded bad CSS (see workaround) we have been used to prior to MDL-49094 being fixed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              lazydaisy Mary Evans
              Peer reviewer:
              Mary Evans
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Ryan Wyllie
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15