[MDL-50932] File cache store doesn't check if file exists if prescan is enabled - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-~~MDL-50932~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...marinaglancy:wip-MDL-50932-master
Testing Instructions:

Hide

run unittests

create instance of file cache with prescan, set it as application cache and wonder around site

Show
run unittests create instance of file cache with prescan, set it as application cache and wonder around site

The code: \cachestore_file->get

        if ($this->prescan && array_key_exists($key, $this->keys)) {

            if (!$ttl || $this->keys[$filename] >= $maxtime && file_exists($file)) {

                $readfile = true;

            } else {

                $this->delete($key);

And in particular, this line:

if (!$ttl || $this->keys[$filename] >= $maxtime && file_exists($file)) {

Parentheses are needed around the TTL and max time checks, otherwise file_exists is completely ignored. Testing it in PHP interpreter:

// Without parentheses.

php > var_dump((true || false && false));

bool(true)

// With parentheses.

php > var_dump(((true || false) && false));

bool(false)

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Frédéric Massart, John Okely, Marina Glancy, Mark Nielsen

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo