[MDL-50957] Division by zero in Gradebook User Report - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
https://github.com/cdsmith-umn/moodle
Pull Master Branch:
mdl-50957
Pull Master Diff URL:
https://github.com/cdsmith-umn/moodle/compare/mdl-50957
Testing Instructions:
Hide

Make sure you have a course created in your Moodle instance.

When viewing the course, click on "Grades" (under "Course administration").

From the drop menu at the top of the page, choose "Categories and items".

Click "Add grade item".

Set "Maximum grade" to 0.

Set "Minimum grade" to -1.

Click "Save changes".

Under "Administration" > "Grade administration" in the side navigation, click "User report".

View your PHP error log and ensure there is no "PHP Warning: Divion by zero" message.
Show
Make sure you have a course created in your Moodle instance. When viewing the course, click on "Grades" (under "Course administration"). From the drop menu at the top of the page, choose "Categories and items". Click "Add grade item". Set "Maximum grade" to 0. Set "Minimum grade" to -1. Click "Save changes". Under "Administration" > "Grade administration" in the side navigation, click "User report". View your PHP error log and ensure there is no "PHP Warning: Divion by zero" message.

When using "sum of grades" and $grademax is zero, a division by zero error occurs in fill_contributions_column() in grade/report/user/lib.php.

Participants:: Adrian Greeve, CiBoT, Clem Smith, Dan Poltawski, David Monllaó, Marina Glancy, Ryan Wyllie

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie