Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50971

Action menus cause page to jump when closing

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Resources

      1. Goto a course with enough contents that you can scroll a resource or activity off screen.
      2. Turn on editing
      3. Open the action menu near the top of the course
      4. Scroll the page without closing the action menu so it is off screen
      5. Click on the page
      6. The view of the page should not change, when you scroll back to the resource the action menu should be closed.

      Keyboard navigation is still works

      1. Turn on editing
      2. Tab through the content until you get to a resource action menu
      3. When you tab onto it the menu and hit space or enter it should open and the top item should be in focus.
      4. If you shift-tab the menu should close and the menu element should be focused.
      5. space or tab the menu open again
      6. tab through till you go past the last element
      7. The menu should be closed and the item in the tab order after the menu selector should be in focus and the action menu closed.

      Blocks

      1. Turn on editing on a page with a block on and enough room to scroll it off screen.
      2. Open the action menu on the block
      3. Scroll the page so the block is off screen without closing the action menu
      4. Click on the page
      5. The page view should not change, when you scroll the block back into view the action menu should be closed.

      Keyboard navigation still works

      1. Turn on editing
      2. Tab through the content until you get to a block action menu
      3. When you tab onto it the menu and hit space or enter it should open and the top item should be in focus.
      4. If you shift-tab the menu should close and the menu element should be focused.
      5. space or tab the menu open again
      6. tab through till you go past the last element
      7. The menu should be closed and the item in the tab order after the menu selector should be in focus and the action menu closed.

      Quizes

      1. As an editing teacher go to a quiz and click the 'Edit quiz' button
      2. Click on the Add action menu
      3. Scroll the page down so that the menu is off screen
      4. Click on the page
      5. The page view should not change, when you scroll back up the action menu should be closed.

      Keyboard navigation

      Keyboard navigation on the quiz action menu is broken both before and after this patch.

      Show
      Resources Goto a course with enough contents that you can scroll a resource or activity off screen. Turn on editing Open the action menu near the top of the course Scroll the page without closing the action menu so it is off screen Click on the page The view of the page should not change, when you scroll back to the resource the action menu should be closed. Keyboard navigation is still works Turn on editing Tab through the content until you get to a resource action menu When you tab onto it the menu and hit space or enter it should open and the top item should be in focus. If you shift-tab the menu should close and the menu element should be focused. space or tab the menu open again tab through till you go past the last element The menu should be closed and the item in the tab order after the menu selector should be in focus and the action menu closed. Blocks Turn on editing on a page with a block on and enough room to scroll it off screen. Open the action menu on the block Scroll the page so the block is off screen without closing the action menu Click on the page The page view should not change, when you scroll the block back into view the action menu should be closed. Keyboard navigation still works Turn on editing Tab through the content until you get to a block action menu When you tab onto it the menu and hit space or enter it should open and the top item should be in focus. If you shift-tab the menu should close and the menu element should be focused. space or tab the menu open again tab through till you go past the last element The menu should be closed and the item in the tab order after the menu selector should be in focus and the action menu closed. Quizes As an editing teacher go to a quiz and click the 'Edit quiz' button Click on the Add action menu Scroll the page down so that the menu is off screen Click on the page The page view should not change, when you scroll back up the action menu should be closed. Keyboard navigation Keyboard navigation on the quiz action menu is broken both before and after this patch.
    • Workaround:
      Hide

      Close an action menu before scrolling a page

      Show
      Close an action menu before scrolling a page
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      If you use an item in an action menu then scroll a page without closing the menu and then click anywhere on the page (for example to try opening another action menu) the page will return the pages focus back to the menu that was left open.

      This can disrupt the flow of a users work.

      Reproducible steps

      1. Open the action menu of a resouce
      2. Scroll the page so it is off screen
      3. Click anywhere on the page
      4. You will be returned to the place in the page you were at when you opened the action menu

      Work around

      Close the action menu before you scroll the page.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15