[MDL-50972] Scorm Auto-commit can't be disabled. - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Pull from Repository:
https://github.com/danmarsden/moodle.git
Pull Master Branch:
master_~~MDL-50972~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...danmarsden:master_MDL-50972
Testing Instructions:
Hide

Turn on API debugging mode in scorm

Add the scorm package attached to ~~MDL-37401~~

Make sure auto commit is turned on in scorm package settings

Open the package and navigate to a SCO.

Stop navigation when you see "LMSSetValue" as the last function call in the debugger.

Wait for 60 seconds, "LMSCommit" should be called automatically.

Test 2
Same instructions as above but turn auto-commit setting "off" within the package
Wait for 60 seconds, make sure "LMSCommit" is not called automatically.
Show
Turn on API debugging mode in scorm Add the scorm package attached to MDL-37401 Make sure auto commit is turned on in scorm package settings Open the package and navigate to a SCO. Stop navigation when you see "LMSSetValue" as the last function call in the debugger. Wait for 60 seconds, "LMSCommit" should be called automatically. Test 2 Same instructions as above but turn auto-commit setting "off" within the package Wait for 60 seconds, make sure "LMSCommit" is not called automatically.

Even if the Auto-commit option is unchecked in both general and module's Scorm configuration, Moodle keeps auto-commiting the sco values.

It looks like the autocommit value is set to a string "0" instead of 0 or false, confirming the test in scorm_13.js l.748

I have to override $scorm->autocommit value in scorm_13.php l.49 to disable the Auto-commit's timeout :

if ($scorm->autocommit == 0) $scorm->autocommit = false ;

has been marked as being related by

MDL-59109 Auto commit SCORM package setting doesn't import properly from a backup

is a regression caused by

MDL-37401 PATCH - SCORM auto-commit

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, Dan Marsden, Dan Poltawski, Loïc POZAS, Matteo Scaramuccia

Component watchers:: Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie