Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50999

commands removed from the wrong place in dock code

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.7, 2.9.1
    • Fix Version/s: 2.8.8, 2.9.2
    • Component/s: Blocks, JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      1. Visit a page with blocks
      2. Ensure that editing is turned off
      3. dock the navigation block
        1. Confirm that it was moved to the dock and removed from view
      4. Mouse over its name in the dock such that it appears
        1. Confirm that it appears
        2. *Confirm that it has two icons (undock + close)
      5. Undock the block
        1. Confirm that it was undocked
        2. *Confirm that it does not have a div in its header with a class of "commands"
      6. Dock the block again
      7. Mouse over it again
        1. *Confirm that the same commands are still visible (undock/close)
      8. Refresh the page
        1. Confirm that the block is docked automatically
        2. *Confirm that mousing over it reveals the same commands (undock/close)
      9. Undock it
        1. Confirm that the undock/close commands are not in the undocked block
        2. *Confirm that div.commands block is not in the undocked block
      10. Turn editing on
      11. Add a "Latest badges" block
        1. Confirm that it has a move icon and a settings cog
      12. Dock the Latest badges block, and the Navigation block
        ## Confirm they were docked
      13. Mouse over the Latest badges block
        1. Confirm that the commands section still contains the settings cog, and additionally the undock, and close icons
      14. Undock it
        1. Confirm that the commands section is still present
        2. Confirm that the settings cog, and move icons are present
        3. Confirm that they are in the div.commands
      15. Mouse over the navigation block in the dock
        1. Confirm that the undock and close icons are visible, alongside the cog
      16. Refresh the page
      17. Mouse over the navigation block in the dock
        1. Confirm that the undock and close icons are visible, alongside the cog
      18. Undock the navigation block
        1. Confirm that the commands section is still present
        2. Confirm that the settings cog, and move icons are present
        3. Confirm that they are in the div.commands

      (Note: The move icon not being drag/drop is a known issue)

      Show
      Visit a page with blocks Ensure that editing is turned off dock the navigation block Confirm that it was moved to the dock and removed from view Mouse over its name in the dock such that it appears Confirm that it appears *Confirm that it has two icons (undock + close) Undock the block Confirm that it was undocked *Confirm that it does not have a div in its header with a class of "commands" Dock the block again Mouse over it again *Confirm that the same commands are still visible (undock/close) Refresh the page Confirm that the block is docked automatically *Confirm that mousing over it reveals the same commands (undock/close) Undock it Confirm that the undock/close commands are not in the undocked block *Confirm that div.commands block is not in the undocked block Turn editing on Add a "Latest badges" block Confirm that it has a move icon and a settings cog Dock the Latest badges block, and the Navigation block ##  Confirm they were docked Mouse over the Latest badges block Confirm that the commands section still contains the settings cog, and additionally the undock, and close icons Undock it Confirm that the commands section is still present Confirm that the settings cog, and move icons are present Confirm that they are in the div.commands Mouse over the navigation block in the dock Confirm that the undock and close icons are visible, alongside the cog Refresh the page Mouse over the navigation block in the dock Confirm that the undock and close icons are visible, alongside the cog Undock the navigation block Confirm that the commands section is still present Confirm that the settings cog, and move icons are present Confirm that they are in the div.commands (Note: The move icon not being drag/drop is a known issue)
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-50999-master

      Description

      As discussed in MDL-48202, the dock code incorrectly modifies markup of the block after it has been undocked. This shoudln't happen.
      Looking at the code, it looks like the offending section is meant to be removed, but it's removed from the wrong place.

      TBH, this code is messy and confusing, but I think that we should try and fix this bit now if we can.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15