Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51013

Navbar button should appear for smaller screens only when the custom menu or language menu is not empty

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Turn off the option to display the language menu under Site administration > Language > Language settings.
      2. Make sure that the custom menu under Site administration > Appearance > Themes > Theme settings is empty.
      3. View your site in Clean using a narrow window
      4. Navbar button does not appear
      5. Turn the language menu on
      6. Navbar button appears
      7. Click the navbar button to reveal the language menu
      8. Add some custom menu items and turn off the language menu
      9. Navbar button remains
      10. Click the navbar button to reveal the custom menu items
      Show
      Turn off the option to display the language menu under Site administration > Language > Language settings. Make sure that the custom menu under Site administration > Appearance > Themes > Theme settings is empty. View your site in Clean using a narrow window Navbar button does not appear Turn the language menu on Navbar button appears Click the navbar button to reveal the language menu Add some custom menu items and turn off the language menu Navbar button remains Click the navbar button to reveal the custom menu items
    • Workaround:
      Hide

      The problem can be overridden in custom themes

      Show
      The problem can be overridden in custom themes
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      wip-MDL-51013-master

      Description

      On smaller screens the bootstrap family of themes displays a button in the upper right that is meant to reveal custom menu items and / or the language menu. If both of those are empty, however, the button still appears. Clicking it does nothing but reveal the border of a collapsed box.

      To reproduce:

      1. Turn off the option to display the language menu under Site administration > Language > Language settings.
      2. Make sure that the custom menu under Site administration > Appearance > Themes > Theme settings is empty.
      3. View your site in Clean using a narrow window

      Expected: There should be no navbar button.
      Actually: The navbar button is there but it has nothing to reveal

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15