Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51016

email_to_user() attachment support broken on Windows

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: This issue must be tested on a range of OS, including:

      1. Linux;
      2. MacOS; and
      3. Windows
      1. Run vendor/bin/phpunit core_messagelib_testcase lib\tests\messagelib_test.php and confirm that test_message_attachment_send passes
      2. Run the tests from MDL-49787 and confim that this patch hasn't broken the functionality introduced in that issue
      Show
      Note: This issue must be tested on a range of OS, including: Linux; MacOS; and Windows Run vendor/bin/phpunit core_messagelib_testcase lib\tests\messagelib_test.php and confirm that test_message_attachment_send passes Run the tests from MDL-49787 and confim that this patch hasn't broken the functionality introduced in that issue
    • Workaround:
      Hide

      Linux

      Show
      Linux
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Sprint:
      Team ';drop tables Sprint 10
    • Issue size:
      Small

      Description

      On running the unit tests on the latest 2.8.7+ (Build: 20150730) - from the zip download - I'm seeing a single failure for core_messagelib_testcase::test_message_attachment_send:

      There was 1 failure:
      		 
       
      		 
      1) core_messagelib_testcase::test_message_attachment_send
      		 
      Failed asserting that false is true.
      		 
       
      		 
      C:\Users\vas07101\dev\htdocs\moodle\lib\tests\messagelib_test.php:859
      		 
      C:\Users\vas07101\dev\htdocs\moodle\lib\phpunit\classes\advanced_testcase.php:80
      		 
       
      		 
      To re-run:
      		 
       C:\Users\vas07101\dev\htdocs\moodle\vendor\bin\/../phpunit/phpunit/composer/bin/phpunit core_messagelib_testcase lib\tests\messagelib_test.php
      		 
       
      		 
      FAILURES!
      		 
      Tests: 1, Assertions: 2, Failures: 1.

      It turns out that this was because the patch for MDL-49787 broke the ability to send attachments with email_to_user() in Windows.

        Attachments

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49787 Email attachements with symlinked temp dir

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              maherne Michael Aherne
              Reporter:
              maherne Michael Aherne
              Peer reviewer:
              Andrew Nicols
              Integrator:
              David Monllaó
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15