Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51016

email_to_user() attachment support broken on Windows

    XMLWordPrintable

Details

    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • Hide

      Linux

      Show
      Linux
    • Hide

      Note: This issue must be tested on a range of OS, including:

      1. Linux;
      2. MacOS; and
      3. Windows
      1. Run vendor/bin/phpunit core_messagelib_testcase lib\tests\messagelib_test.php and confirm that test_message_attachment_send passes
      2. Run the tests from MDL-49787 and confim that this patch hasn't broken the functionality introduced in that issue
      Show
      Note: This issue must be tested on a range of OS, including: Linux; MacOS; and Windows Run vendor/bin/phpunit core_messagelib_testcase lib\tests\messagelib_test.php and confirm that test_message_attachment_send passes Run the tests from MDL-49787 and confim that this patch hasn't broken the functionality introduced in that issue
    • Team ';drop tables Sprint 10
    • Small

    Description

      On running the unit tests on the latest 2.8.7+ (Build: 20150730) - from the zip download - I'm seeing a single failure for core_messagelib_testcase::test_message_attachment_send:

      There was 1 failure:
       
      1) core_messagelib_testcase::test_message_attachment_send
      Failed asserting that false is true.
       
      C:\Users\vas07101\dev\htdocs\moodle\lib\tests\messagelib_test.php:859
      C:\Users\vas07101\dev\htdocs\moodle\lib\phpunit\classes\advanced_testcase.php:80
       
      To re-run:
       C:\Users\vas07101\dev\htdocs\moodle\vendor\bin\/../phpunit/phpunit/composer/bin/phpunit core_messagelib_testcase lib\tests\messagelib_test.php
       
      FAILURES!
      Tests: 1, Assertions: 2, Failures: 1.
      

      It turns out that this was because the patch for MDL-49787 broke the ability to send attachments with email_to_user() in Windows.

      Attachments

        Issue Links

          Activity

            People

              maherne Michael Aherne
              maherne Michael Aherne
              Andrew Lyons Andrew Lyons
              David Monllaó David Monllaó
              Rajesh Taneja Rajesh Taneja
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Sep/15