Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
2.8.7, 2.9.1
-
MOODLE_28_STABLE, MOODLE_29_STABLE
-
MOODLE_28_STABLE, MOODLE_29_STABLE
-
wip-mdl-51101
-
- Nightly results should be enough
Description
There are several "I hover" steps mis-used in order to check the state of Completion checking:
mod/forum/tests/behat/completion_condition_number_discussions.feature: Then I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_forum ')]/descendant::img[@alt='Not completed: Test forum name']" "xpath_element"
|
mod/forum/tests/behat/completion_condition_number_discussions.feature: And I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_forum ')]/descendant::img[contains(@alt, 'Completed: Test forum name')]" "xpath_element"
|
mod/lesson/tests/behat/completion_condition_end_reached.feature: Then I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_lesson ')]/descendant::img[@alt='Not completed: Test lesson']" "xpath_element"
|
mod/lesson/tests/behat/completion_condition_end_reached.feature: And I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_lesson ')]/descendant::img[@alt='Not completed: Test lesson']" "xpath_element"
|
mod/lesson/tests/behat/completion_condition_end_reached.feature: And I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_lesson ')]/descendant::img[@alt='Completed: Test lesson']" "xpath_element"
|
mod/lesson/tests/behat/completion_condition_time_spent.feature: Then I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_lesson ')]/descendant::img[@alt='Not completed: Test lesson']" "xpath_element"
|
mod/lesson/tests/behat/completion_condition_time_spent.feature: And I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_lesson ')]/descendant::img[@alt='Not completed: Test lesson']" "xpath_element"
|
mod/lesson/tests/behat/completion_condition_time_spent.feature: And I hover "//li[contains(concat(' ', normalize-space(@class), ' '), ' modtype_lesson ')]/descendant::img[@alt='Completed: Test lesson']" "xpath_element"
|
From what I can tell, and dmonllao may be able to confirm, these steps are used to ascertain whether the specified xpath is present on the page. They're essentially being used instead of:
"//...." "xpath_element" should exist
|
Three things need to happen:
- These should be turned into a single step:
the "My elaborate forum name" "forum" activity should (not) be marked as complete - We should stop using I hover!!
- We should find all uses of this and determine whether we can remove the javascript tag