Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51127

RTL button group is badly styled in context header

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Using Clean theme and logged in as Admin select English (en) from the language menu if not already set.
      2. Go to Messages and select the name of a User who is listed as being on-line in order to view their profile.
      3. Verify that the Message button in this user profile page is far right and at the end of the text line of the page just inside the page padding (20px).
      4. As previous test but also verify that the two buttons 'Reset page to default' and 'Customise this page' are side by side and line up on the right to the edge of the page just below the 'Message' button.
      5. Still on the same page, select Hebrew (he) from the language menu and verify that the 'Message' button is now far left and at the end of the text line of the page just in-side the page padding (20px).
      6. As No.4 above, but all buttons line up on the left side of the page.
      Show
      Using Clean theme and logged in as Admin select English (en) from the language menu if not already set. Go to Messages and select the name of a User who is listed as being on-line in order to view their profile. Verify that the Message button in this user profile page is far right and at the end of the text line of the page just inside the page padding (20px). As previous test but also verify that the two buttons 'Reset page to default' and 'Customise this page' are side by side and line up on the right to the edge of the page just below the 'Message' button. Still on the same page, select Hebrew (he) from the language menu and verify that the 'Message' button is now far left and at the end of the text line of the page just in-side the page padding (20px). As No.4 above, but all buttons line up on the left side of the page.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-51127-master

      Description

      The RTL equivalent css should almost always mimic the opposite of its LTR counterpart.

      The .dir-rtl .context-button-group however seems to have been style as a last ditch effort adding a right: -15px; instead of trying to find the source of the actual problem, that of the whole button group css in that area which is wrong.

      .dir-ltr .page-context-header {
          .page-header-image {
              float: left;
              margin-right: 1em;
          }
          .header-button-group {
              float: right;
          }
      }
       
      .dir-rtl .page-context-header {
          .page-header-image {
              float: right;
              margin-left: 1em;
          }
       
          .header-button-group {
              float: left;
              right: -15px;
          }
      }
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Nov/15