[MDL-51131] Deleting course deletes its tags instead of tag instances - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
~~MDL-51131~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/6d392b3...MDL-51131-master
Testing Instructions:
Hide

Enable $CFG->block_tags_showcoursetags

Add "Tags" block to the course

Add a tag to the course with the same name as existing tag (for example the tag that was present in some user's preferences)

Delete the course

Make sure the tag is still present elsewhere (for example in some user's preferences)
Show
Enable $CFG->block_tags_showcoursetags Add "Tags" block to the course Add a tag to the course with the same name as existing tag (for example the tag that was present in some user's preferences) Delete the course Make sure the tag is still present elsewhere (for example in some user's preferences)

Enable $CFG->block_tags_showcoursetags
Add "Tags" block to the course
Add a tag to the course with the same name as existing tag (for example the tag that was present in some user's preferences)
Delete the course
The tag is completely deleted, and vanished from user's preferences

blocks

MDL-51132 MOODLE 3.0: Drop user-course-tagging and replace with normal course-tagging

Discovered while testing

MDL-50851 Introduce tag collections and tag callbacks (Tag API overhaul)

is a regression caused by

MDL-40908 Replace add_to_log with an event trigger - tag

Participants:: CiBoT, Dan Poltawski, David Monllaó, Frédéric Massart, Marina Glancy, Simey Lameze

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)