Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51132

MOODLE 3.0: Drop user-course-tagging and replace with normal course-tagging

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      before upgrade:

      1. Enable $CFG->block_tags_showcoursetags
      2. Add block 'Tags' to the course, login as several users and tag the course with different/intersecting tags
      3. search for these tags (Site pages>Tags), make sure the related courses are displayed
      4. upgrade
      5. make sure the block 'Tags' is now disabled sitewide and does not appear in any courses
      6. search tags and make sure the same courses are displayed as before upgrade
      7. as teacher/manager make sure you can edit tags using course Edit settings form
      8. create new role that has capability 'moodle/course/tag' only; assign this role to a user
      9. login as this user, go to the course (you may not be able to access the course, only the info.php page), click on "Course administration > Edit tags"
      10. make sure you can edit tags
      11. make sure the tags are still searchable and the relavant courses are displayed
      Show
      before upgrade: Enable $CFG->block_tags_showcoursetags Add block 'Tags' to the course, login as several users and tag the course with different/intersecting tags search for these tags (Site pages>Tags), make sure the related courses are displayed upgrade make sure the block 'Tags' is now disabled sitewide and does not appear in any courses search tags and make sure the same courses are displayed as before upgrade as teacher/manager make sure you can edit tags using course Edit settings form create new role that has capability 'moodle/course/tag' only; assign this role to a user login as this user, go to the course (you may not be able to access the course, only the info.php page), click on "Course administration > Edit tags" make sure you can edit tags make sure the tags are still searchable and the relavant courses are displayed
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-51132-master
    • Pull Master Diff URL:

      Description

      There is a non obvious possibility in Moodle allowing users to tag courses. There are so many bugs there (and no bug reports) that I doubt anybody uses it. However it prevents us from using normal course tagging.

      This issue suggests:

      • remove all "coursetags" functionality such as block setting ($CFG->block_tags_showcoursetags), pages to add/edit "my" course tags
      • during upgrade automatically convert all existing course tags into proper user-less tags
      • add a field in course edit form that will allow teacher/manager to set or change course tags similar as one can set user interests, blog tags, question tags, wiki pages tags, etc.
      • everybody will still be able to search for tagged courses using /tag/search.php

      API changes:
      Going to delete/deprecate quite a few of things including

      • drop capability 'moodle/tag:create'

      forum post: https://moodle.org/mod/forum/discuss.php?d=318395

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-52045 The block Tags still displays Settings link in the admin UI

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          New Feature - A new Moodle feature which has yet to be developed. MDL-50851 Introduce tag collections and tag callbacks (Tag API overhaul)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43077 Update button on tag editting page is not display properly and action notice displayed as plain text.

          • Major - Major loss of function, incorrect output
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51131 Deleting course deletes its tags instead of tag instances

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          New Feature - A new Moodle feature which has yet to be developed. MDL-36648 Write new course tagging infrastructure

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Damyon Wiese Damyon Wiese
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              2 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15