Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51181

Documentation of $CFG->lock_factory in config-dist.php is wrong

    XMLWordPrintable

    Details

      Description

      The documentation for the $CFG->lock_factory config setting in config-dist.php is:

      // Moodle 2.7 introduces a locking api for critical tasks (e.g. cron).
      // The default locking system to use is DB locking for MySQL and Postgres, and File
      // locking for Oracle and SQLServer. If $CFG->preventfilelocking is set, then the default
      // will always be DB locking.

      This is not what actually happens in lock_config::get_lock_factory(), as only Postgres has its own specific implementation. It should be something like:

      // Moodle 2.7 introduces a locking api for critical tasks (e.g. cron).
      // The default locking system to use is DB locking for Postgres, and file locking for
      // MySQL, Oracle and SQLServer. If $CFG->preventfilelocking is set, then the default
      // will always be DB locking.

        Attachments

          Activity

            People

            Assignee:
            maherne Michael Aherne
            Reporter:
            maherne Michael Aherne
            Peer reviewer:
            Damyon Wiese
            Integrator:
            David Monllaó
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            David Mudrák (@mudrd8mz), Helen Foster, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/15