Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51181

Documentation of $CFG->lock_factory in config-dist.php is wrong

    XMLWordPrintable

Details

    Description

      The documentation for the $CFG->lock_factory config setting in config-dist.php is:

      // Moodle 2.7 introduces a locking api for critical tasks (e.g. cron).
      // The default locking system to use is DB locking for MySQL and Postgres, and File
      // locking for Oracle and SQLServer. If $CFG->preventfilelocking is set, then the default
      // will always be DB locking.

      This is not what actually happens in lock_config::get_lock_factory(), as only Postgres has its own specific implementation. It should be something like:

      // Moodle 2.7 introduces a locking api for critical tasks (e.g. cron).
      // The default locking system to use is DB locking for Postgres, and file locking for
      // MySQL, Oracle and SQLServer. If $CFG->preventfilelocking is set, then the default
      // will always be DB locking.

      Attachments

        Activity

          People

            maherne Michael Aherne
            maherne Michael Aherne
            Damyon Wiese Damyon Wiese
            David Monllaó David Monllaó
            Frédéric Massart Frédéric Massart
            Aya Saad, David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              14/Sep/15