Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51201

Empty string passed to getElementById() when clicking on navigation collapse button.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 2.9.1
    • Fix Version/s: None
    • Component/s: JavaScript, Themes
    • Labels:
    • Affected Branches:
      MOODLE_29_STABLE
    • Testing Instructions:
      Hide
      1. Use FireFox.
      2. Select the Clean theme.
      3. Minimise the screen such that the navigation collapse button is shown.
      4. Open the console on the browser (F12).
      5. Click on the button.
      6. Observe the error.
      Show
      Use FireFox. Select the Clean theme. Minimise the screen such that the navigation collapse button is shown. Open the console on the browser (F12). Click on the button. Observe the error.

      Description

      When in the Clean theme you reduce the size of the screen to get the 'navigation collapse' button then click on it, then the following error is shown on the console:

      Empty string passed to getElementById().
      

      This kills JavaScript for that element and prevents further operation when themes are modified to react to it. In the Clean theme, nothing is actually broken, however, the tale of woe can be seen on: https://github.com/gjb2048/moodle-theme_essential/issues/530 - where the simple CSS selector attribute change on 'visibility' causes further use of the button inoperable.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              gb2048 Gareth J Barnard
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated: