Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51215

"Manage courses" button doesn't properly consider rights of current user

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Assign user a manager role only in some categories, not system-wide
      2. Login as this user and browse courses
      3. Make sure the "Manage courses" button appears only in the categories where that user is a manager
      4. Make sure that clicking on this button takes to the management page of this category
      Show
      Assign user a manager role only in some categories, not system-wide Login as this user and browse courses Make sure the "Manage courses" button appears only in the categories where that user is a manager Make sure that clicking on this button takes to the management page of this category
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-51215-master

      Description

      The Manage Courses button appears to assume that the current user is a Manager assigned at site level.

      Assume for a moment that the site has, say, 4 categories and the user is only a Manager in one of them. When they click this button they are always taken to the "first" (alphabetically I assume) category regardless of them having the right to actually "manage" it or not.

      I'm not entirely clear what the intent of this button was (as opposed to "Manage this category") but I think it should either...

      • only be displayed when the current user has the relevant capability assigned at the Site level
      • it should be more intelligent about expanding in a category that the user can actually manage. In most cases this will be a parent of the category they are currently active in.
      • Just do the same thing as "Edit this category".

      Before you assume that it doesn't really matter - this really annoys/confuses real users as this big button in the "Turn editing on" position is much more prominent than the "Edit this category" link in the Administration block.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15